Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is quite important for effective array slicing, but not previously exposed. (The value could easily be hard-coded at each use site, but that would make for cryptic code, not to mention unsafe if the definition of af_span should ever change.)
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The special value
spanis quite important for effective array slicing in ArrayFire, but it was not previously exposed in the Haskell bindings. Indeed, as this is a constant rather than a function it cannot be imported (?) using the FFI, but the same value can simply be hardcoded as a Haskell constant.Without this export, users could also hard-code it at each use site. But that would result in cryptic code, not to mention unsafe if the definition of
af_spanshould ever change. It's certainly better to have it available in the library.