Conversation

dignifiedquire

Closes #861,#843

@dignifiedquire

@jbr @yoshuawuyts any ideas about the CI issues, they are quite odd. Suddenly there are missing crates Oo, seems like a CI bug, as this works fine locally.

@jbr

Agreed that it seems to be a CI issue, but I don't think it's related to this PR. See CI failures at https://.com/async-rs/async-std/pull/853/checks?check_run_id=988260537

Maybe it's related to caching? Does it help to temporarily comment out L32-48 of ci.yml?

@jbr

@dignifiedquire See the above PR for a possible long-term solution to the wasm/no-std problem, but at the cost of requiring all wasm users to enable a wasm feature, which would be a breaking change. I have no idea how to get both no-std and wasm compiling simultaneously without that, though, and don't understand how it ever worked

@Fishrock123

This seems fine to me, although me and @jbr were discussing with @yoshuawuyts last week and Yosh noted that just getting it to build may not be enough and actual was builds could still have issues when run in their environments.

I'm not so invested in that personally but is something that may be good to track, both for async-std and http-rs.

@dignifiedquiredignifiedquire changed the title Fix wasm fix wasm and nostd builds Sep 14, 2020
@dignifiedquiredignifiedquire merged commit e9cb238 into master Sep 14, 2020
@dignifiedquiredignifiedquire deleted the fix-wasm branch September 14, 2020 19:31
@dignifiedquire

yes we need to run the tests as well, I had wasm-bindgen-test working at some point on my machine, but forgot the magical invocations..

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

CI check for wasm isn't working