Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…[]string vs inetrpolated into single cmdLine)
Open
Comment on lines +425 to +426
| err := cmd.Start() | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err := cmd.Start() | |
| if err != nil { | |
| if err := cmd.Start(); err != nil { |
I would very much appreciate having this slice-based Exec! Is this PR being considered? |
| ```go | ||
| args := []string{}; | ||
| args = append(args,"127.0.0.1") | ||
| script.Exec("ping",args).Stdout() |
There was a problem hiding this comment.
Would that be Execv?
Suggested change
| script.Exec("ping",args).Stdout() | |
| script.Execv("ping", args).Stdout() |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
Really enjoying using
scripthowever there have been a couple of use cases where I have wanted to avoid interpolating theExecargs into a single cmdLIne (and worrying about quoting - which can be complex if dealing with arbitrary input) and have therefore added anExecv(cmd string, args []string)method which passes the cmd and args separately as []string (which is what gets passed to exec.Command anyway so saves re-parsing the command line).Think this would be a useful addition (and be safer for scripts which make need to Exec commands where some of the parameters are untrusted)