Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds "identifier" to checkstyle output, which we can use to generate a more friendly check name on our side. codeclimate/csslint@e8b8855
Instead of "net.csslint.Disallow@import" (source, which is a munged rule.name), just use "import" (rule.id).
| @@ -20,7 +20,7 @@ def run | |||
| next unless node.name == "error" | |||
| lint = node.attributes | |||
| check_name = lint["source"].value | |||
| check_name = lint["identifier"].value | |||
There was a problem hiding this comment.
should this be prefixed in the resulting json?
There was a problem hiding this comment.
Nope. Any check-prefixing is meant to be done from the outside. RuboCop's current behavior notwithstanding, that's the future we want to build for -- so says @brynary anyway.
@gordondiggs you good on this? |
LGTM |
pbrisbin added a commit that referenced this pull request Dec 8, 2015
Use rule identifier as check name
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of "net.csslint.Disallow@import" (source, which is a munged rule.name),
just use "import" (rule.id).
/cc @codeclimate/review