Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits August 16, 2016 17:03
Instead of crashing out when encountering a parse error, this will report the issue as a parse error.
| if node.attributes.key?("identifier") | ||
| create_issue(node, path) | ||
| else | ||
| create_error(node, path) |
There was a problem hiding this comment.
This approach introduces an unacceptable amount of syntactic duplication IMO. What do you think of instead doing the following:
check_nameis (basically)node.identifier || "parse-error"- Have a
check_detailsvalue that mapsparse-errorto[BugRisk]/5_000 - Everything else about
#create_issuestays as-is - No need for
#create_error
There was a problem hiding this comment.
Good points all around. Will do all of that.
@pbrisbin cleaned up |
2de1b57 to 4968a34 Compare | require "shellwords" | ||
| module CC | ||
| module Engine | ||
| MissingAttributesError = Class.new(StandardError) | ||
| DEFAULT_IDENTIFIER = OpenStruct.new(value: "parse-error") |
LGTM. Nice fix. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of crashing out when encountering a parse error, this will report
the issue as a parse error.
cc @codeclimate/review a bit different from other engines because we're not outputting to stderr, but this seems useful.