Conversation

Koooooo-7

Summary

Redirect output root path to docs/index.html since we remove the root index.html under #2316 .
If it is acceptable, we could merge it into #2316 and move on.

Update:
Custom -pages publish flow to adapt index.html changes.

Related issue, if any:

What kind of change does this PR introduce?

Repo settings

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed
    Non core functions related changes.

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercelVercel

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 4, 2023 9:16am

sy-records
sy-records previously requested changes Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is not without preview. use cdn resources instead of lib.

@Koooooo-7

But it is not without preview. use cdn resources instead of lib.

Because we import the CND resources in index.html.
I gonna update it.

@Koooooo-7

It works with local resources now.

@Koooooo-7

Update:
The pages branch gh-pages for publish (Pages branch).
Action: deploy-gh
Rewrite result: index.html
(Copy /lib action is similar operations)

@Koooooo-7Koooooo-7 marked this pull request as ready for review December 4, 2023 08:29
@Koooooo-7Koooooo-7 marked this pull request as draft December 4, 2023 08:37
@Koooooo-7Koooooo-7 changed the title chore: config vercel. action: refactor config vercel and pages publish. Dec 4, 2023
@Koooooo-7Koooooo-7 marked this pull request as ready for review December 4, 2023 09:55
@jhildenbiddle

@Koooooo-7 --

I've addressed the Vercel deployment issue in #2316.

Base automatically changed from replace-live-server to develop December 11, 2023 21:00
@sy-recordssy-records deleted the pr-2316 branch December 22, 2023 05:27
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.