Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I ran into a bunch of warnings when using Elastic results with Ruby 2.4+ and trailblazer/cells, because `#method_missing?` without `#respond_to_missing?` makes Forwardable think all of the Result attributes are private methods. https://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding
Apologies to @nutsoriginal, I didn't see his PR (#727) until opening this one. Anyway, this has some test coverage. |
respond_to_missing? to silence Ruby 2.4 warningsrespond_to_missing? to silence Ruby 2.4 warnings I've signed the CLA. |
Thanks @emptyflask and @nutsoriginal |
estolfo pushed a commit that referenced this pull request Oct 17, 2018
I ran into a bunch of warnings when using Elastic results with Ruby 2.4+ and trailblazer/cells, because `#method_missing?` without `#respond_to_missing?` makes Forwardable think all of the Result attributes are private methods. https://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding
vanboom added a commit to vanboom/elasticsearch-rails that referenced this pull request Nov 10, 2023
…nt, fix index name to klass lookup methodology
vanboom added a commit to vanboom/elasticsearch-rails that referenced this pull request Nov 11, 2023
…ic#838 and improve autoloader compatibility
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I ran into a bunch of warnings when using Elastic results with
Ruby 2.4+ and trailblazer/cells, because
#method_missing?without#respond_to_missing?makes Forwardable think all of the Resultattributes are private methods.
https://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding