Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add extensive test coverage for VM opcodes including: - Basic operations (OpLoadEnv, OpTrue, OpFalse, OpNil) - Arithmetic operations (OpNegate, OpExponent) - String operations (OpEqualString, OpMatches) - Collection operations (OpIn, OpLen) - Type operations (OpCast) - Control flow (OpThrow) - Function calls (OpCall0-3, OpCallN) - Index and count manipulation (OpGetIndex, OpSetIndex) - Profiling operations (OpProfileStart, OpProfileEnd) Also add high-level expression tests for: - Arithmetic expressions - String operations - Data structure operations - Group and sort operations Each test case includes detailed comments and covers both success and error cases. These tests combined with a debugger helped me navigate the VM internals significantly. Signed-off-by: Ville Vesilehto <[email protected]>
Awesome! Cool to see nice tests added. |
Coverage increases: 91% => 91.3% |
6ef04ec into expr-lang:master 12 checks passed
Uh oh!
There was an error while loading. Please reload this page.
SimFG pushed a commit to SimFG/expr that referenced this pull request Apr 15, 2025
Add extensive test coverage for VM opcodes including: - Basic operations (OpLoadEnv, OpTrue, OpFalse, OpNil) - Arithmetic operations (OpNegate, OpExponent) - String operations (OpEqualString, OpMatches) - Collection operations (OpIn, OpLen) - Type operations (OpCast) - Control flow (OpThrow) - Function calls (OpCall0-3, OpCallN) - Index and count manipulation (OpGetIndex, OpSetIndex) - Profiling operations (OpProfileStart, OpProfileEnd) Also add high-level expression tests for: - Arithmetic expressions - String operations - Data structure operations - Group and sort operations Each test case includes detailed comments and covers both success and error cases. These tests combined with a debugger helped me navigate the VM internals significantly. Signed-off-by: Ville Vesilehto <[email protected]>
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add extensive test coverage for VM opcodes including:
Also add high-level expression tests for:
Each test case includes detailed comments and covers both success and error cases.
These tests combined with a debugger helped me navigate the VM internals significantly.