Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thank you @guneemwelloeux for your contribution! Would you be able to check the failing CIs? Thanks! |
9ac6080 to 2119ca3 Compare firebase_admin/__init__.py Outdated
| @@ -307,3 +309,5 @@ def _cleanup(self): | |||
| if hasattr(service, 'close') and hasattr(service.close, '__call__'): | |||
| service.close() | |||
| self._services = None | |||
| App.update | |||
There was a problem hiding this comment.
It is. Just pushed an update to my branch. I did run the unit tests before, all passed.
lahirumaramba requested changes Mar 30, 2023
Draft
2119ca3 to 357278d Compare Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This relates to issue #626