Conversation

pragatimodi

TOTP Support for Project and Tenant

RELEASE NOTES: Added TOTP as a multi-factor option in project and tenant configuration.

@pragatimodi
1. Adding Multi Factor Auth Configuration
44586d7
2. Added TOTP Support for Tenant
3. Added Unit Tests for MFA Config
4. Added Unit Tests for Tenant Config with respect to MFA
@pragatimodi
Updating list[ProviderConfig] to List[ProviderConfig]
b625e13
@pragatimodi
1. Added a project_config_mgt file
c002232
2. Unit tests for project_config_mgt
3. Formatting changes
@pragatimodipragatimodi marked this pull request as draft March 15, 2023 20:32
@pragatimodipragatimodi marked this pull request as ready for review March 21, 2023 18:35
@lahirumarambalahirumaramba added release-note release:stageStage a release candidatelabels Mar 29, 2023
lahirumaramba
lahirumaramba reviewed Mar 29, 2023
View reviewed changes
lahirumaramba and others added 3 commits May 26, 2023 10:59
@lahirumaramba @pragatimodi
chore: Fix pypy tests (#694)
7e53e61
@pragatimodi
chore(auth): Update Auth API to v2 (#691)
6a4f451
* `v2beta1` -> `v2`

* Reverting auto formatting changes

* undo auto formatting
@samueldg @lahirumaramba @pragatimodi
Add release notes to project URLs in PyPI (#679)
0684915
It's useful to be able to navigate to the release notes easily
from the package index when upgrading.

"Release Notes" is a special keyword that will have the scroll icon
in the project page.

A random example:

* https://pypi.org/project/streamlit/
* https://.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111

Co-authored-by: Lahiru Maramba <[email protected]>
@pragatimodipragatimodi force-pushed the mfa-totp branch 2 times, most recently from cd7aed2 to 0684915 Compare May 26, 2023 18:03
renkelvin
renkelvin reviewed Jun 1, 2023
View reviewed changes
@pragatimodipragatimodi requested a review from renkelvin June 2, 2023 15:43
Xiaoshouzi-gh
Xiaoshouzi-gh reviewed Jun 7, 2023
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments.

@pragatimodi
Addressing feedback
8b87e10
Importing configs directly

fix warnings

fix warnings

fix warnings
kevinthecheung
kevinthecheung requested changes Jun 14, 2023
View reviewed changes
kevinthecheung
kevinthecheung approved these changes Sep 8, 2023
View reviewed changes
@pstrav

@kevinthecheung @Xiaoshouzi-gh do we have an ETA on this? Thanks!

Sign up for free to join this conversation on . Already have an account? Sign in to comment

@renkelvin renkelvin renkelvin approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

No one assigned
release:stageStage a release candidaterelease-note
None yet
No milestone

Successfully merging this pull request may close these issues.