Conversation

skion

This adds two exception types to enable users to detect rate limited calls which were previously swallowed and converted into a generic InvalidArgumentError, making it impossible to detect rate limiting situations and pass that information through to the end user.

This is being discussed in #666.

I chose to inherit from the ResourceExhaustedError base exception, which seemed to make most sense.

@google-cla

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@skionskion marked this pull request as ready for review April 13, 2023 20:34
@skion

@pragatimodi Since you are assigned to #666, would you be able to check this out?

@skionskion force-pushed the rate-limiting branch 2 times, most recently from 190b7c8 to 4ad0339 Compare November 15, 2023 20:54
@skion

@jonathanedey I see you are mostly maintaining this repo now, is this something you could have a look at?

@lahirumarambalahirumaramba linked an issue Mar 5, 2024that may be closed by this pull request
@pragatimodipragatimodi self-requested a review March 5, 2024 17:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skion, This looks great. Thank you so much for your patience in getting this added!

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

[FR] Improve exception handling for rate limiting