Conversation

jonathanedey

Related to #704

@jonathanedeyjonathanedey linked an issue Oct 24, 2023that may be closed by this pull request
app_check.verify_token can also raise PyJWKClientError, but that is not documented #704
Closed
@jonathanedeyjonathanedey self-assigned this Oct 24, 2023
@jonathanedeyjonathanedey marked this pull request as ready for review October 24, 2023 13:31
egilmorez
egilmorez approved these changes Oct 24, 2023
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With one small nit, good from a verbiage perspective, thanks!

@jonathanedeyjonathanedey requested review from lahirumaramba and removed request for hsubox76 November 14, 2023 22:02
lahirumaramba
lahirumaramba approved these changes Nov 15, 2023
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jonathanedeyjonathanedey merged commit c77608e into master Nov 15, 2023
@jonathanedeyjonathanedey deleted the je-pyjwk-error branch November 15, 2023 20:20
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@egilmorez egilmorez egilmorez approved these changes

@jonathanedey jonathanedey

api: appcheck release-note
None yet
No milestone

Successfully merging this pull request may close these issues.

app_check.verify_token can also raise PyJWKClientError, but that is not documented