Merged

chore: Update PyPi to use trusted publisher for authentication and correctly escape change log body. #759

Show file tree
Hide file tree
Changes from all commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a37c87
fix: Escape release tag body and change PyPi to use trusted publisher…
jonathanedeyJan 19, 2024
2d5ba86
fix typo
jonathanedeyJan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
Original file line numberDiff line numberDiff line change
Expand Up@@ -173,7 +173,7 @@ echo "$CHANGELOG"
# and https://.com//docs/issues/21529#issue-1418590935
FILTERED_CHANGELOG=`echo "$CHANGELOG" | grep -v "\\[INFO\\]"`
echo "changelog<<CHANGELOGEOF" >> $_OUTPUT
echo "$FILTERED_CHANGELOG" >> $_OUTPUT
echo -e "$FILTERED_CHANGELOG" >> $_OUTPUT
echo "CHANGELOGEOF" >> $_OUTPUT


Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -92,6 +92,11 @@ jobs:
startsWith(.event.pull_request.title, '[chore] Release ')

runs-on: ubuntu-latest
permissions:
# Used to create a short-lived OIDC token which is given to PyPi to identify this workflow job
# See: https://docs..com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#adding-permissions-settings
# and https://docs.pypi.org/trusted-publishers/using-a-publisher/
id-token: write

steps:
- name: Checkout source for publish
Expand All@@ -116,10 +121,7 @@ jobs:
--notes "${{ steps.preflight.outputs.changelog }}"

- name: Publish to Pypi
uses: pypa/[email protected]
with:
user: firebase
password: ${{ secrets.PYPI_PASSWORD }}
uses: pypa/gh-action-pypi-publish@release/v1

# Post to Twitter if explicitly opted-in by adding the label 'release:tweet'.
- name: Post to Twitter
Expand Down