Merged
Changes from 1 commit
Show all changes
15 commitsSelect commit Hold shift + click to select a range
721b46d
fix(firestore): expose on FireStoreSettings
93a56f8
fix(firestore): expose on FireStoreSettings
921b46b
fix(firestore): change experimentalForceLongPolling to webExperimenta…
SelaseKaybfc142b
feat(firestore, web): expose (webExperimentalAutoDetectLongPolling, w…
SelaseKay51f2056
correct variable name
SelaseKay4b6f081
abstract timeoutDuration within an object
SelaseKay4cce27a
remove description on webExperimentalLongPollingOptions field
SelaseKay4c08161
resolve documentation
SelaseKayb8f2e58
fix analyzer issues
SelaseKayb8a9b92
test(firestore, web): add e2e tests for long polling fields
SelaseKay8283e58
test(firestore, web): add e2e tests for long polling fields
SelaseKayac53e87
remove skip field from test
SelaseKay75ec398
remove unused import
SelaseKay9ba6925
tests(firestore,web): make adjustments long polling tests
SelaseKay2c36f41
tests(firestore,web): make adjustments long polling tests
SelaseKayFile filter
Filter by extension
Conversations
Failed to load comments.
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Failed to load files.
Uh oh!
There was an error while loading. Please reload this page.
feat(firestore, web): expose (webExperimentalAutoDetectLongPolling, w…
…ebExperimentalForceLongPolling, timeoutSeconds)
- Loading branch information
Uh oh!
There was an error while loading. Please reload this page.
commit bfc142b2cdbd20fdea5b0a79ac2da45672e0b8be
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing timeoutSeconds exposed in the user facing lib. I think it should be hidden being an objet like in the original web SDK. experimentalLongPollingOptions