Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea reviewed May 16, 2025
packages/core/src/tracing/trace.ts Outdated
| const incomingDsc = baggageHeaderToDynamicSamplingContext(baggage); | ||
| const baggageOrgId = incomingDsc?.org_id; | ||
| let sdkOrgId: string | undefined; |
There was a problem hiding this comment.
m: I think we should use the same logic here as for injecting the org id, which is use the specified one if defined, else extract it from dsn? We may also put this into a reusable utility, I suppose!
mydea reviewed May 16, 2025
packages/core/src/tracing/trace.ts Outdated
| sdkOrgId = extractOrgIdFromDsnHost(dsn.host); | ||
| } | ||
| const shouldStartNewTrace = (): boolean => { |
There was a problem hiding this comment.
l: Let's maybe make this a separate function that takes arguments instead of inlining this function? No strong feelings, but this is how we usually do this I suppose 🤔
There was a problem hiding this comment.
yeah no strong opinions about this. Just thought it's not a lot of logic and when inlining this it does not disrupt you from the code-reading flow but it still keeps this part of the code separated :D
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This implements
strictTraceContinuationbased on those docs: https://develop.sentry.dev/sdk/telemetry/traces/#stricttracecontinuationcloses #16291