Conversation

bcoe

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@github-actionsGitHub Actions

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser23.93 kB--
@sentry/browser - with treeshaking flags23.7 kB--
@sentry/browser (incl. Tracing)38.23 kB+0.07%+25 B 🔺
@sentry/browser (incl. Tracing, Replay)76.38 kB+0.07%+48 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.48 kB+0.06%+41 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)81.14 kB+0.06%+44 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)93.22 kB+0.04%+36 B 🔺
@sentry/browser (incl. Feedback)40.68 kB--
@sentry/browser (incl. sendFeedback)28.64 kB--
@sentry/browser (incl. FeedbackAsync)33.53 kB--
@sentry/react25.71 kB--
@sentry/react (incl. Tracing)40.24 kB+0.11%+43 B 🔺
@sentry/vue28.26 kB--
@sentry/vue (incl. Tracing)40.05 kB+0.08%+32 B 🔺
@sentry/svelte23.95 kB--
CDN Bundle25.22 kB--
CDN Bundle (incl. Tracing)38.4 kB+0.1%+38 B 🔺
CDN Bundle (incl. Tracing, Replay)74.26 kB+0.08%+55 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)79.69 kB+0.07%+50 B 🔺
CDN Bundle - uncompressed73.59 kB--
CDN Bundle (incl. Tracing) - uncompressed113.64 kB+0.12%+126 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed227.61 kB+0.06%+126 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.44 kB+0.06%+126 B 🔺
@sentry/nextjs (client)41.91 kB+0.11%+43 B 🔺
@sentry/sveltekit (client)38.73 kB+0.09%+34 B 🔺
@sentry/node149.82 kB+0.01%+1 B 🔺
@sentry/node - without tracing98.09 kB--
@sentry/aws-serverless123.83 kB--

View base workflow run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! I think this is great and it also solves #16194 (which I connected to this issue). For the future, if we find use cases for users wanting to exclude all resource spans, we could also add a boolean to the option.

@Lms24Lms24 linked an issue May 26, 2025that may be closed by this pull request
@codecovCodecov

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error parsing JUnit XML in /home/runner/work/sentry-javascript/sentry-javascript/packages/solidstart/vitest.junit.xml at 383:33

Caused by:
    RuntimeError: Error parsing XML
    
    Caused by:
        0: ill-formed document: expected `</testsuite>`, but `</testsuite</</testsuites>` was found
        1: expected `</testsuite>`, but `</testsuite</</testsuites>` was found

For more help, visit our troubleshooting guide.

@bcoebcoe merged commit c297bf9 into develop May 26, 2025
124 checks passed
@bcoebcoe deleted the ignore-resource-spans branch May 26, 2025 17:46
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Add trackResources option to browserTracingIntegration