Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea added a commit that referenced this pull request Jun 13, 2025
…16566) Extracted out from #16565 I noticed that our `modulesIntegration` is pretty limited: 1. It does nothing on EMS 2. It does not work on Next.js (even though that is CJS) This PR makes this a bit more robust (not perfect): 1. It generally now also tries to look at `process.cwd() + 'package.json'` and take the dependencies and devDependencies from there. this should generally work in esm apps now as well, at least at a basic level. You do not get all dependencies and versions may be ranges, but better than nothing. 2. For Next.js, we inject a modules list based off the package.json at build time, as we do not have proper access to this at runtime.
8468a42 to c95356d Compare Especially for next.js, this should work to avoid manual setup.
d669da2 to 9dcfd4f Compare AbhiPrasad approved these changes Jun 13, 2025
d35030d into develop 145 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Would you consider adding a way to disable this? We have some legacy ai sdk code and we hit a build error. I don't have time to create a repro at this time. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of the
aiinstrumentation to always be enabled when we detect theaimodule is installed.For this, we leverage the
modulesIntegration. This PR should make usage of ai instrumentation in Next.js "automatically" again - BUT users will have to specificexperimental_telemetry: { isEnabled: true },at each call manually for the time being.