Merged

fix(opentelemetry): Ensure only orphaned spans of sent spans are sent #16590

Changes from 1 commit
Show all changes
3 commits
Select commit Hold shift + click to select a range
233afed
fix(opentelemetry): Ensure unsent spans are ignored in span exporter
mydeaJun 16, 2025
024562c
add test
mydeaJun 16, 2025
56572a3
fix ai-test
mydeaJun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
Next Next commit
fix(opentelemetry): Ensure unsent spans are ignored in span exporter
  • Loading branch information
@mydea
mydea committedJun 16, 2025
commit 233afedc97158237117a907f98dfa0fde0b6ba53
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,9 +180,6 @@ export class SentrySpanExporter {

this.flushSentSpanCache();
const sentSpans = this._maybeSend(finishedSpans);
for (const span of finishedSpans) {
this._sentSpans.set(span.spanContext().spanId, Date.now() + DEFAULT_TIMEOUT * 1000);
}

const sentSpanCount = sentSpans.size;
const remainingOpenSpanCount = finishedSpans.length - sentSpanCount;
Expand All@@ -191,7 +188,10 @@ export class SentrySpanExporter {
`SpanExporter exported ${sentSpanCount} spans, ${remainingOpenSpanCount} spans are waiting for their parent spans to finish`,
);

const expirationDate = Date.now() + DEFAULT_TIMEOUT * 1000;

for (const span of sentSpans) {
this._sentSpans.set(span.spanContext().spanId, expirationDate);
const bucketEntry = this._spansToBucketEntry.get(span);
if (bucketEntry) {
bucketEntry.spans.delete(span);
Expand Down