Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There are a few bugs in the way we read a pipe or socket name for the TRACE2 event target. We do not correctly trim the \\.\pipe\ prefix on Windows, if present. On Unix we do not correctly strip the af_unix: prefix correctly if a socket file path contains a ':'. Let's fix this! Signed-off-by: Matthew John Cheetham <[email protected]>
In a message that is formatted/parameterised, we incorrectly use the field name of 'format' rather than 'fmt'. Fix this. Signed-off-by: Matthew John Cheetham <[email protected]>
dscho approved these changes Apr 30, 2025
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed a few problems with the TRACE2 support when writing to a pipe/socket. The handling of the
trace2.eventTargetsetting to get the correct pipe name/socket file path was incorrect resulting in names like "pipe\foobar" when given "//./pipe/foobar" on Windows, when it should be "foobar".Also the event field name 'format' is incorrect; it should be 'fmt'.