Conversation

badhezi

Fixes #34591

A reference regarding the deletion of issue webhooks on : https://docs..com/en/webhooks/webhook-events-and-payloads?actionType=deleted#issues

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging.label Jun 3, 2025
@github-actions-actions bot added the modifies/goPull requests that update Go codelabel Jun 3, 2025
@badhezibadhezi marked this pull request as ready for review June 3, 2025 07:10
@lunny

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go
It's better to have a ref links to 's webhook docs in the pull request content.

@lunnylunny added this to the 1.25.0 milestone Jun 3, 2025
@lunnylunny added the type/enhancementAn improvement of existing functionalitylabel Jun 3, 2025
@badhezi

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go It's better to have a ref links to 's webhook docs in the pull request content.

I added tests for both issue and pull request delete.

It's better to have a ref links to 's webhook docs in the pull request content.

I didn't quite understand what you meant by that, can you explain?

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged.and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging.labels Jun 4, 2025
@lunny

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go It's better to have a ref links to 's webhook docs in the pull request content.

I added tests for both issue and pull request delete.

It's better to have a ref links to 's webhook docs in the pull request content.

I didn't quite understand what you meant by that, can you explain?

I updated the content and add a reference link to 's webhook documentation directly.

@lunny

last call @go-gitea/technical-oversight-committee

Sign up for free to join this conversation on . Already have an account? Sign in to comment
lgtm/need 1This PR needs approval from one additional maintainer to be merged.modifies/goPull requests that update Go codemodifies/translation type/enhancementAn improvement of existing functionality
None yet

Successfully merging this pull request may close these issues.

Deletion of issue does not trigger webhook