Conversation

silverwind

Followup #34751, fix all remaining marked issues.

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging.label Jun 18, 2025
@github-actions-actions bot added the modifies/goPull requests that update Go codelabel Jun 18, 2025
@silverwindsilverwind added the type/refactoringExisting code has been cleaned up. There should be no new functionality.label Jun 18, 2025
@silverwindsilverwind changed the title Fix remaining issues after modernize formatting Fix remaining issues after gopls modernize formatting Jun 18, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged.and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging.labels Jun 18, 2025
wxiaoguang
wxiaoguang approved these changes Jun 18, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what // from the fixtures means now ......

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged.labels Jun 18, 2025
@silverwind

It refers to the removed variable:

expectedIssueCount := 20 // from the fixtures

I guess we can make it more clear.

silverwind
silverwind commented Jun 18, 2025
View reviewed changes
silverwind
silverwind commented Jun 18, 2025
View reviewed changes
silverwind
silverwind commented Jun 18, 2025
View reviewed changes
silverwind
silverwind commented Jun 18, 2025
View reviewed changes
lunny
lunny reviewed Jun 18, 2025
View reviewed changes
lunny
lunny reviewed Jun 18, 2025
View reviewed changes
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon.label Jun 18, 2025
@lunnylunny added this to the 1.25.0 milestone Jun 18, 2025
@lunnylunny merged commit 46a1d52 into go-gitea:main Jun 18, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon.label Jun 18, 2025
@wxiaoguangwxiaoguang deleted the modfix branch June 18, 2025 23:31
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8f883a1
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade `gopls` to v0.19.0, add `make fix` (go-gitea#34772)
  Refactor packages (func name & UI) (go-gitea#34773)
  Fix remaining issues after `gopls modernize` formatting (go-gitea#34771)
  Fix some package registry problems (go-gitea#34759)
  Fix incorrect cli default values and default command (go-gitea#34765)
  Support annotated tags when using create release API (go-gitea#31840)
  when using rules to delete packages, remove unclean bugs (go-gitea#34632)
  Fix readme path and markdown link paste (go-gitea#34755)
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@lunny lunny lunny left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

No one assigned
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/refactoringExisting code has been cleaned up. There should be no new functionality.
None yet
1.25.0

Successfully merging this pull request may close these issues.