This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Conversation

codyoss

No description provided.

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Dec 11, 2019
@codyoss

Before this can work two PRs need to be merged and their artifacts released:

Will update this PR after that happens

@codyosscodyoss added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Dec 11, 2019
@codecov

Codecov Report

Merging #92 into master will increase coverage by 0.21%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     66.43%   66.64%   +0.21%     
- Complexity      367      370       +3     
============================================
  Files            34       34              
  Lines          1865     1877      +12     
  Branches        236      240       +4     
============================================
+ Hits           1239     1251      +12     
  Misses          524      524              
  Partials        102      102
Impacted FilesCoverage ΔComplexity Δ
...va/com/google/cloud/http/HttpTransportOptions.java56.94% <100%> (+0.6%)10 <0> (ø)⬇️
...src/main/java/com/google/cloud/ServiceOptions.java44.26% <81.25%> (+2.53%)33 <3> (+3)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4df8f...f53a167. Read the comment docs.

@codyosscodyoss removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Dec 13, 2019
@codyosscodyoss marked this pull request as ready for review December 13, 2019 18:30
@codyosscodyoss requested a review from a team December 13, 2019 18:31
@codyosscodyoss requested a review from chingor13 December 13, 2019 21:05
chingor13
chingor13 suggested changes Dec 13, 2019
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small testing nit

@codyosscodyoss requested a review from chingor13 December 13, 2019 22:59
chingor13
chingor13 suggested changes Dec 13, 2019
View reviewed changes
@codyosscodyoss merged commit 6aa4476 into googleapis:master Dec 13, 2019
@codyosscodyoss deleted the quota-project branch December 13, 2019 23:37
@release-pleaserelease-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.

@elharo elharo elharo left review comments

@chingor13 chingor13 chingor13 approved these changes

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.