This repository was archived by the owner on Dec 3, 2023. It is now read-only.
Merged

feat: support setting ServiceOption for quota project #92

Changes from 1 commit
Show all changes
7 commits
Select commit Hold shift + click to select a range
af9f8e6
feat: support setting ServiceOption for quota project
codyossDec 11, 2019
7720f55
add test for order of setting quota project
codyossDec 13, 2019
34d7beb
remove old test
codyossDec 13, 2019
12102a9
add project id to test
codyossDec 13, 2019
b6f5eaf
reverse order
codyossDec 13, 2019
e635406
use the correct setter
codyossDec 13, 2019
f53a167
add one more test case
codyossDec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
PrevPrevious commit
Next Next commit
add project id to test
  • Loading branch information
@codyoss
codyoss committedDec 13, 2019
commit 12102a902b2c3b4b46855979cecd52925e204c81
Original file line numberDiff line numberDiff line change
Expand Up@@ -320,6 +320,7 @@ public void testBuilder_quotaProjectServiceOptionTakesPrecedence() {
TestServiceOptions noCredsWithQuotaProject =
TestServiceOptions.newBuilder()
.setCredentials(NoCredentials.getInstance())
.setQuotaProjectId("project-id")
.setQuotaProjectId("quota-project-id")
.build();
TestServiceOptions quotaProjectCredsWithQuotaProject =
Expand All@@ -330,7 +331,10 @@ public void testBuilder_quotaProjectServiceOptionTakesPrecedence() {
TestServiceOptions quotaProjectCreds =
TestServiceOptions.newBuilder().setCredentials(credentialsWithQuotaProject).build();
TestServiceOptions none =
TestServiceOptions.newBuilder().setCredentials(NoCredentials.getInstance()).build();
TestServiceOptions.newBuilder()
.setCredentials(NoCredentials.getInstance())
.setQuotaProjectId("project-id")
.build();

assertEquals("quota-project-id", noCredsWithQuotaProject.getQuotaProjectId());
assertEquals("quota-project-id", quotaProjectCredsWithQuotaProject.getQuotaProjectId());
Expand Down