Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
docs: clarify transaction semantics PiperOrigin-RevId: 452634948 Source-Link: googleapis/googleapis@df51ec8 Source-Link: https://.com/googleapis/googleapis-gen/commit/25426f6fd17c5229e17a1f37858cb6c1738f0cad Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjU0MjZmNmZkMTdjNTIyOWUxN2ExZjM3ODU4Y2I2YzE3MzhmMGNhZCJ9
rajatbhatta approved these changes Jun 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ansh0l suggested changes Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a change to avoid accidental merge, since do-not-merge label is not blocking the release. Triaging that separately.
Neenu1995 approved these changes Jun 6, 2022
PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9
PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9
PiperOrigin-RevId: 458877561 Source-Link: googleapis/googleapis@207bf59 Source-Link: https://.com/googleapis/googleapis-gen/commit/5ede6e4fbc14d76f9a6f48152a16d8141d8aff52 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWVkZTZlNGZiYzE0ZDc2ZjlhNmY0ODE1MmExNmQ4MTQxZDhhZmY1MiJ9
@ansh0l (I guess you added this label across pull requests) Is there a blocker for this particular pull request? |
ansh0l approved these changes Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 14, 2022
🤖 I have created a release *beep* *boop* --- ## [6.26.0](v6.25.7...v6.26.0) (2022-07-13) ### Features * Adding two new fields for Instance create_time and update_time ([#1908](#1908)) ([00b3817](00b3817)) * changes to support data, timestamp and arrays in IT tests ([#1840](#1840)) ([c667653](c667653)) * Error Details Improvement ([c8a2184](c8a2184)) * Error Details Improvement ([#1929](#1929)) ([c8a2184](c8a2184)) ### Bug Fixes * enable longpaths support for windows test ([#1485](#1485)) ([#1946](#1946)) ([fd0b845](fd0b845)) ### Dependencies * update dependency com.google.cloud:google-cloud-trace to v2.3.0 ([#1934](#1934)) ([2813eb2](2813eb2)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please). See [documentation](https://.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Dec 5, 2023
…p/templates/java_library/.kokoro (#1908) build(deps): bump cryptography Bumps [cryptography](https://.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply..com> Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65
arpan14 pushed a commit that referenced this pull request Dec 15, 2023
…p/templates/java_library/.kokoro (#1908) (#2752) build(deps): bump cryptography Bumps [cryptography](https://.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply..com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply..com>
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API. owl-bot-copy size: xlPull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 458877561
Source-Link: googleapis/googleapis@207bf59
Source-Link: https://.com/googleapis/googleapis-gen/commit/5ede6e4fbc14d76f9a6f48152a16d8141d8aff52
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWVkZTZlNGZiYzE0ZDc2ZjlhNmY0ODE1MmExNmQ4MTQxZDhhZmY1MiJ9
fix: update gapic-generator-java with mock service generation fixes
PiperOrigin-RevId: 457524730
Source-Link: googleapis/googleapis@917e7f2
Source-Link: https://.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9
feat: Enable REST transport for most of Java and Go clients
PiperOrigin-RevId: 456641589
Source-Link: googleapis/googleapis@8a251f5
Source-Link: https://.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9
chore: Integrate new gapic-generator-java and rules_gapic
PiperOrigin-RevId: 454027580
Source-Link: googleapis/googleapis@1b22277
Source-Link: https://.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9
feat: add Session creator role
docs: clarify transaction semantics
PiperOrigin-RevId: 452634948
Source-Link: googleapis/googleapis@df51ec8
Source-Link: https://.com/googleapis/googleapis-gen/commit/25426f6fd17c5229e17a1f37858cb6c1738f0cad
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjU0MjZmNmZkMTdjNTIyOWUxN2ExZjM3ODU4Y2I2YzE3MzhmMGNhZCJ9