Conversation

olavloite

DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a DatabaseNotFound error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC.

If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database.

Fixes #16

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 14, 2020
@olavloiteolavloite added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 14, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 14, 2020
hengfengli
hengfengli approved these changes Jan 17, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olavloiteolavloite added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 20, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 20, 2020
@olavloite
fix: stop sending rpcs on deleted db
948ba36
@olavloite
fix: client should stop sending rpcs after database dropped
6a35e03
DatabaseClients should not continue to try to send RPCs to a database that has
been deleted. Instead, the session pool will keep track of whether a database
not found error has been returned for a database, and if so, will invalidate
itself. All subsequent calls for this database will return a DatabaseNotFoundException
without calling a RPC.

If a database is re-created, the user must create a new DatabaseClient with a new
session pool in order to resume usage of the database.

Fixes #16
@olavloite
fix: remove double check on isValid
8a83158
@olavloite
fix: add wait to deleted db integration test
3a8f221
@olavloite
fix: process review comments
ed29deb
@olavloite
fix: update copyright year
dd6c56b
@olavloiteolavloite merged commit 11e4a90 into master Jan 22, 2020
@olavloiteolavloite deleted the database-deleted branch January 22, 2020 06:40
@yoshi-automationyoshi-automation mentioned this pull request Jan 23, 2020
Merged
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu skuruppu approved these changes

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.

spanner: Client library sending a high rate of BeginTransaction requests when database is deleted