Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Any error that might occur during the listing of databases of an instance will now also include the name of the instance and the page token that was used to try to get the databases. This makes it easier to debug why a particular RPC might have failed. Closes #17
skuruppu approved these changes Jan 30, 2020
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Any error that might occur during the listing of databases of an instance will now also include the name of the instance and the page token that was used to try to get the databases. This makes
it easier to debug why a particular RPC might have failed.
The flaky fails mentioned in #17 have not occurred for a while, and it is very well possible that this problem was a temporary backend problem. This extra information will make it easier to debug the failures should they occur again.
Closes #17