Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Since the backup tests are very expensive, here we exercise the PITR functionality along with the existing backup tests. We also remove the dedicated backup tests for PITR.
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
============================================
+ Coverage 85.19% 85.22% +0.02%
- Complexity 2648 2651 +3
============================================
Files 145 145
Lines 14358 14358
Branches 1391 1391
============================================
+ Hits 12233 12237 +4
+ Misses 1543 1541 -2
+ Partials 582 580 -2
Continue to review full report at Codecov.
|
olavloite approved these changes Mar 15, 2021
| try { | ||
| return operation.get(); | ||
| } catch (ExecutionException e) { | ||
| if (e.getCause() != null && e.getCause() instanceof SpannerException) { |
There was a problem hiding this comment.
nit: null-check is redundant, as null instanceof whatever always returns false
There was a problem hiding this comment.
Thanks, fixed it.
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the backup tests are very expensive, here we exercise the PITR functionality along with the existing backup tests. We also remove the dedicated backup tests for PITR.
Fixes #948