Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
athakor reviewed Dec 23, 2019
| @@ -0,0 +1,2 @@ | |||
| releaseType: java-yoshi | |||
| bumpMinorPreMajor: true | |||
| env_vars: { | ||
| key: "JOB_TYPE" | ||
| value: "lint" | ||
| } |
| env_vars: { | ||
| key: "JOB_TYPE" | ||
| value: "lint" | ||
| } |
| env_vars: { | ||
| key: "JOB_TYPE" | ||
| value: "clirr" | ||
| } |
| env_vars: { | ||
| key: "TRAMPOLINE_BUILD_FILE" | ||
| value: "/java-storage/.kokoro/linkage-monitor.sh" | ||
| } |
| env_vars: { | ||
| key: "TRAMPOLINE_BUILD_FILE" | ||
| value: "/java-storage/.kokoro/release/snapshot.sh" | ||
| } |
| mvn nexus-staging:release -B \ | ||
| -DperformRelease=true \ | ||
| --settings=settings.xml | ||
| fi |
| "repo": "googleapis/google-cloud-java", | ||
| "repo_short": "google-cloud-java", | ||
| "repo": "googleapis/java-storage", | ||
| "repo_short": "java-storage", | ||
| "distribution_name": "com.google.cloud:google-cloud-storage", | ||
| "api_id": "storage.googleapis.com" | ||
| } |
| </modules> | ||
| </profile> | ||
| </profiles> | ||
| </project> |
| "path": "__pycache__/synth.cpython-36.pyc" | ||
| } | ||
| ] | ||
| } |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage ? 63.29%
Complexity ? 528
=========================================
Files ? 30
Lines ? 4719
Branches ? 450
=========================================
Hits ? 2987
Misses ? 1571
Partials ? 161Continue to review full report at Codecov.
|
codyoss approved these changes Dec 26, 2019
@athakor These are common templates and should be addressed globally. I opened googleapis/synthtool#357 to track |
BenWhitehead added a commit that referenced this pull request May 2, 2022
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:
wip: first stab at trying to corral all {to,from}Pb methods from model classes
# This is the commit message #2:
wip: refactor all access of ApiaryConversions to use their intermediary `codec` method
# This is the commit message #2:
wip: add clirr rule to allow removing accidental public hmacKeyMetadata#toPb
# This is the commit message #2:
wip: add enum ApiaryConversions#Codecs
# This is the commit message #3:
wip: fix lifecycle rule tests
# This is the commit message #4:
wip: fix blob metadata encoding
# This is the commit message #5:
wip: replace Blob#fromPb and Bucket#fromPb with BlobInfo#asBlob and BucketInfo#asBucket
The old fromPb method were conflating creating an instance of an "Info" model with create an instance of an "Info" model and binding it together with a Storage instance.
Now, an instance of Info model can be decoded (where/whenever) and then turned into a Blob/Bucket as necessary.
# This is the commit message #6:
tersify conversionsSign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.