Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BenWhitehead approved these changes Jun 21, 2021
| * | ||
| * @param storageUrl the Storage url to create the blob from | ||
| */ | ||
| public static BlobId fromStorageUrl(String storageUrl) { |
There was a problem hiding this comment.
Maybe fromGsutilUri instead of storage? To my knowledge, there are many different types of storage URLs
https://storage.googleapis.com/bucket/blobhttps://storage.cloud.google.com/bucket/blob
In the cloud console these format of URI are labeled gsutil URI
Comment on lines 132 to 133
| String bucketName = storageUrl.split("/")[2]; | ||
| String blobName = storageUrl.split(bucketName + "/")[1]; |
There was a problem hiding this comment.
Possibly simplify string allocation and traversal?
Suggested change
| String bucketName = storageUrl.split("/")[2]; | |
| String blobName = storageUrl.split(bucketName + "/")[1]; | |
| int blobNameStartIndex = storageUrl.indexOf('/', 5); | |
| String bucketName = storageUrl.substring(5, blobNameStartIndex); | |
| String blobName = storageUrl.substring(blobNameStartIndex); |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds options for creating a blob ID from a storage url and vice versa. Fixes #868