Conversation

vinnysenthil

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 3 of 5) 🦕

issues raised by this PR: #51 , #52

@vinnysenthilvinnysenthil requested review from dizcology and a team as code owners September 25, 2020 21:59
@vinnysenthilvinnysenthil requested review from kurtisvg and removed request for a team September 25, 2020 21:59
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Sep 25, 2020
@release-pleaserelease-please bot requested a review from a team as a code owner September 25, 2020 23:09
kurtisvg
kurtisvg suggested changes Sep 26, 2020
View reviewed changes
@product-auto-labelproduct-auto-label bot added the samplesIssues that are directly related to samples.label Sep 26, 2020
@dizcologydizcology added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 29, 2020
@busunkim96busunkim96 added kokoro:force-runAdd this label to force Kokoro to re-run the tests.and removed kokoro:force-runAdd this label to force Kokoro to re-run the tests.labels Sep 29, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 29, 2020
@busunkim96

The usual flow is to merge to the main branch and then cut the release PR. Is it possible to change the branch you are merging into to master?

@dizcology This is likely also the the samples presubmit is missing. The kokoro configs added in #16 aren't present in the release-v0.2.0 branch.

@vinnysenthilvinnysenthil changed the base branch from release-v0.2.0 to sample-final-stage September 30, 2020 23:41
kurtisvg
kurtisvg suggested changes Oct 2, 2020
View reviewed changes
@snippet-bot

Here is the summary of possible violations 😱

There are 14 possible violations for not having product prefix.

Here is the summary of changes.

You added 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

kurtisvg
kurtisvg suggested changes Nov 9, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copy/pasted several comments from previous reviews that weren't addressed.

@aribrayaribray requested a review from kurtisvg November 10, 2020 17:10
kurtisvg
kurtisvg reviewed Nov 10, 2020
View reviewed changes
kurtisvg
kurtisvg suggested changes Nov 10, 2020
View reviewed changes
@aribrayaribray requested a review from kurtisvg November 11, 2020 01:39
@kurtisvg

Please include the issue number for tracking the outstanding work before submitting.

This was referencedNov 11, 2020
Closed
Closed
@dizcologydizcology merged commit efc405f into sample-final-stage Nov 11, 2020
@sgreenbergsgreenberg mentioned this pull request Nov 12, 2020
Closed
@vinnysenthilvinnysenthil deleted the sample-staging-3 branch December 3, 2021 08:41
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@aribray aribray aribray left review comments

@dizcology dizcology dizcology approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@aribray aribray

cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.
None yet
No milestone

Successfully merging this pull request may close these issues.