Conversation

vinnysenthil

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 5 of 5) 🦕

@vinnysenthilvinnysenthil requested review from dizcology and a team as code owners September 25, 2020 22:01
@vinnysenthilvinnysenthil requested review from tmatsuo and removed request for a team September 25, 2020 22:01
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Sep 25, 2020
@release-pleaserelease-please bot requested a review from a team as a code owner September 25, 2020 23:09
@product-auto-labelproduct-auto-label bot added the samplesIssues that are directly related to samples.label Sep 26, 2020
@vinnysenthilvinnysenthil changed the base branch from release-v0.2.0 to sample-final-stage September 30, 2020 23:44
@vinnysenthilvinnysenthil requested review from busunkim96 and removed request for tmatsuo October 1, 2020 02:08
busunkim96
busunkim96 reviewed Oct 1, 2020
View reviewed changes
@busunkim96busunkim96 mentioned this pull request Oct 1, 2020
Closed
munkhuushmgl
munkhuushmgl reviewed Nov 6, 2020
View reviewed changes
@snippet-bot

Here is the summary of changes.

You added 12 region tags.

To update this comment, add snippet-bot:force-run label.

@dizcologydizcology merged commit b982be3 into sample-final-stage Nov 12, 2020
@aribrayaribray mentioned this pull request Nov 12, 2020
Closed
@vinnysenthilvinnysenthil deleted the sample-staging-5 branch December 3, 2021 08:41
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@aribray aribray aribray left review comments

@dizcology dizcology dizcology approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@munkhuushmgl munkhuushmgl Awaiting requested review from munkhuushmgl

@aribray aribray

cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.
None yet
No milestone

Successfully merging this pull request may close these issues.