Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
shollyman approved these changes Feb 16, 2022
| @@ -442,6 +444,12 @@ def _create_dataset_if_necessary(client, dataset_id): | |||
| "this option's value in the context bqstorage_client_options." | |||
| ), | |||
| ) | |||
| @magic_arguments.argument( | |||
| "--no_query_cache", | |||
| action="store_true", | |||
There was a problem hiding this comment.
I'm not understanding what this "store_true" is about, but it seems consistent with the other arguments.
There was a problem hiding this comment.
That's behavior IPython/Jupyter inherits from argparse https://docs.python.org/3/library/argparse.html#action
The gist is that if this argument is present it'll set args.no_query_cache = True rather than requiring a boolean parameter.
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
… query cache
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 215520997 🦕