Merged

feat: add --no_query_cache option to %%bigquery magics to disable… #1141

Show file tree
Hide file tree
Changes from all commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be255f
feat: add `--no_query_cache` option to `%%bigquery` magics to disable…
tswastFeb 16, 2022
d3fae05
Merge branch 'main' into b215520997-magics-no-cache
tswastFeb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@
A dataset and table to store the query results. If table does not exists,
it will be created. If table already exists, its data will be overwritten.
Variable should be in a format <dataset_id>.<table_id>.
* ``--no_query_cache`` (Optional[line argument]):
Do not use cached query results.
* ``--project <project>`` (Optional[line argument]):
Project to use for running the query. Defaults to the context
:attr:`~google.cloud.bigquery.magics.Context.project`.
Expand DownExpand Up@@ -442,6 +444,12 @@ def _create_dataset_if_necessary(client, dataset_id):
"this option's value in the context bqstorage_client_options."
),
)
@magic_arguments.argument(
"--no_query_cache",
action="store_true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding what this "store_true" is about, but it seems consistent with the other arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's behavior IPython/Jupyter inherits from argparse https://docs.python.org/3/library/argparse.html#action

The gist is that if this argument is present it'll set args.no_query_cache = True rather than requiring a boolean parameter.

default=False,
help=("Do not use cached query results."),
)
@magic_arguments.argument(
"--use_bqstorage_api",
action="store_true",
Expand DownExpand Up@@ -642,6 +650,10 @@ def _cell_magic(line, query):
job_config.use_legacy_sql = args.use_legacy_sql
job_config.dry_run = args.dry_run

# Don't override context job config unless --no_query_cache is explicitly set.
if args.no_query_cache:
job_config.use_query_cache = False

if args.destination_table:
split = args.destination_table.split(".")
if len(split) != 2:
Expand Down