Conversation

rshk

Requests with multipart/form-data were handled incorrectly, preventing file upload functionality from working.

I fixed GraphQLView to support file uploads according to the specification.

This is currently used in production to receive file uploads via apollo-upload-client.

Haven't really tested on Py2 or <3.6, test suite seems to be happy though.

@rshkrshk mentioned this pull request Jul 24, 2018
@coveralls

Coverage Status

Coverage decreased (-9.3%) to 84.247% when pulling 84583cf on rshk:support-multipart-requests into 4183613 on graphql-python:master.

1 similar comment
@coveralls

Coverage Status

Coverage decreased (-9.3%) to 84.247% when pulling 84583cf on rshk:support-multipart-requests into 4183613 on graphql-python:master.

@coveralls

Coverage Status

Coverage increased (+1.07%) to 94.615% when pulling 9e69073 on rshk:support-multipart-requests into 4183613 on graphql-python:master.

@rshkrshk force-pushed the support-multipart-requests branch from 84583cf to c67fc48 Compare July 24, 2018 21:51
@rshkrshk force-pushed the support-multipart-requests branch from 5aafca9 to 52e647f Compare July 25, 2018 12:20
@Fenkiou

Any update on this?

@sabard

I've been using graphene-file-upload for now. Code looks to be doing pretty much the same thing as this.

Will be nice to consolidate when this gets merged in.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.