Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's me again with a type hints issue. I'm writing a custom field resolver:
and have
disallow_untyped_calls = True
in mymypy
config. Running the type check yieldsI'd thus propose to add at least a rudimentary typing to
graphql.execute.default_field_resolver
for now. Once Python 3.6 and 3.7 are dropped, I suppose a better typing using protocols could be possible.Signed-off-by: oleg.hoefling [email protected]