Description

This PR is to add TOTP feature to auth.

Related issues

#7483

Release Summary

Adds TOTP feature to auth.

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x ] Yes
• My change supports the following platforms;
  • [ x ] Android
  • [ x ] iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• [ x ] I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • [ x ] No

Test Plan

Currently working on the tests but would like some feedback before I write a ton of tests if the way I wrote it won't be accepted.

Whats left

• Write e2e test
• Validate ios implementation is valid

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2024 9:11pm

All committers have signed the CLA.

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

I am sorry - I reviewed this but did not submit the review 🤦 - it looks like a good start (especially at the native level, which is usually the most difficult!) but is not consistent with firebase-js-sdk yet so needs a bit of a re-shape on the API we expose

[mikehardy]

Interesting - I don't think this is strictly necessary? It is not present in the firebase-js-sdk so we need to change this to make sure we are 100% consistent with them.

What I think we need is to add FactorId.TOTP to the FactorIdMap and package the TOTP information in to the MultiFactorAssertion so we can use it in the enroll API above

Then this API is not needed

hey what's needed to get this merged in? happy to help. we have users who have TOTP from our web product enabled and as soon as they get to the app the whole thing just crashes atm without this PR.