Conversation

bentsku

As described in #80, we had an issue with newer beta versions of the AWS Provider, due to some services endpoint being removed.

As we still support them in LocalStack for now, we cannot fully remove those endpoints, and are only removing them if the AWS Provider version is >= 6.0.0-beta2.

We are doing by trying to read the .terraform.lock.hcl created by the init command, containing the provider version. As the endpoint overrides does not matter for the init command for those endpoints, we should be good to go.
I'm not sure there would be a better way to resolve the provider version, and if there even any.

@bentskubentsku requested a review from cloutierMat June 6, 2025 22:30
@bentskubentsku self-assigned this Jun 6, 2025
@bentskubentsku marked this pull request as draft June 6, 2025 22:39
@bentskubentsku marked this pull request as ready for review June 6, 2025 22:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rapid fix to this issue. It is awesome to address those while the tf version is still in beta 👍

Comment on lines +137 to +140
VERSIONED_SERVICE_EXCLUSIONS = {
"iotanalytics": {"min": version.Version("0"), "max": version.Version("6.0.0b2")},
"iotevents": {"min": version.Version("0"), "max": version.Version("6.0.0b2")},
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice future thinking!

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.