Conversation

DavesCodeMusings

The aioble README already has this fix: 57ce3ba

This makes a similar correction to the temp_sensor.py example.

Similar to fix already applied to README micropython@57ce3ba
@DavesCodeMusingsDavesCodeMusings changed the title Fix units in ADV_INTERVAL constant Fix units in ADV_INTERVAL constant. Oct 4, 2024
@DavesCodeMusingsDavesCodeMusings changed the title Fix units in ADV_INTERVAL constant. /micropython/bluetooth/aioble/examples/temp_client.py: Fix units in ADV_INTERVAL constant. Oct 4, 2024
@dpgeorge

Thanks for the contribution. Line 53 will also need fixing, as per the CI error.

Also, probably worth fixing the examples/l2cap_file_server.py example as well?

@DavesCodeMusings

@dpgeorge Unfortunately, I found out about the guidelines for commits after I submitted a pull request. So yeah, there are some things I need to straighten out. Getting there... slowly. Still trying to figure out how I can do all this from the .com web interface. Not so sure about the git -s signing bit. Can that be done in a browser or command-line only?

@dpgeorge

Not so sure about the git -s signing bit. Can that be done in a browser or command-line only?

It should work through the browser now, I just enabled the relevant setting. If you add a new commit it should be signed.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.