error on variables that are used but never initialized by Zzzen · Pull Request #55887 · microsoft/TypeScript ·

Fixes #23305

The TypeScript team hasn't accepted the linked issue #23305. If you can get it accepted, this PR will have a better chance of being reviewed.

Zzzen · 2023-09-27T06:42:55Z

src/compiler/checker.ts

@@ -2147,7 +2147,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 var deferredGlobalClassAccessorDecoratorResultType: GenericType | undefined;
 var deferredGlobalClassFieldDecoratorContextType: GenericType | undefined;

-var allPotentiallyUnusedIdentifiers = new Map<Path, PotentiallyUnusedIdentifier[]>(); // key is file name
+var allPotentiallyUnusedOrUninitializedIdentifiers = new Map<Path, PotentiallyUnusedIdentifier[]>(); // key is file name


Will allLocalIdentifiers be a better variable name?

…ariables

error on variables that are used but never uninitialized

I assume you meant “initialized” here.

src/compiler/types.ts

@typescript-bot

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top300
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot perf test this

@DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at ff025b3. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at ff025b3. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at ff025b3. You can monitor the build here.

@DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at ff025b3. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at ff025b3. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at ff025b3. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157977/artifacts?artifactName=tgz&fileId=042CD02ADCF3ACCA8F8A1966AF9CB028ABA7B1793581431400BBC70BDA43B29F02&fileName=/typescript-5.3.0-insiders.20230927.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@DanielRosenwasser

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/55887/merge:

Everything looks good!

@DanielRosenwasser

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/55887/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

pyright

/mnt/ts_downloads/pyright/build.sh

[NEW] error TS2454: Variable 'key' is used before being assigned.
- /mnt/ts_downloads/pyright/pyright: ../pyright-internal/src/analyzer/types.ts(906,17)
- /mnt/ts_downloads/pyright/pyright: ../pyright-internal/src/analyzer/types.ts(935,13)
- /mnt/ts_downloads/pyright/pyright-internal: src/analyzer/types.ts(906,17)
- /mnt/ts_downloads/pyright/pyright-internal: src/analyzer/types.ts(935,13)
- /mnt/ts_downloads/pyright/vscode-pyright: ../pyright-internal/src/analyzer/types.ts(906,17)
- /mnt/ts_downloads/pyright/vscode-pyright: ../pyright-internal/src/analyzer/types.ts(935,13)
[NEW] error TS2454: Variable 'entry1' is used before being assigned.
- /mnt/ts_downloads/pyright/pyright: ../pyright-internal/src/analyzer/types.ts(907,17)
- /mnt/ts_downloads/pyright/pyright-internal: src/analyzer/types.ts(907,17)
- /mnt/ts_downloads/pyright/vscode-pyright: ../pyright-internal/src/analyzer/types.ts(907,17)
[NEW] error TS2454: Variable 'entry2' is used before being assigned.
- /mnt/ts_downloads/pyright/pyright: ../pyright-internal/src/analyzer/types.ts(936,13)
- /mnt/ts_downloads/pyright/pyright-internal: src/analyzer/types.ts(936,13)
- /mnt/ts_downloads/pyright/vscode-pyright: ../pyright-internal/src/analyzer/types.ts(936,13)

@DanielRosenwasser

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,981k (± 0.01%)}	_{296,154k (± 0.01%)}	_{+1,173k (+ 0.40%)}	_296,108k	_296,188k	_{p=0.005 n=6}
_{Parse Time}	_{2.63s (± 0.50%)}	_{2.63s (± 0.65%)}	_~	_2.61s	_2.65s	_{p=0.928 n=6}
_{Bind Time}	_{0.83s (± 0.98%)}	_{0.83s (± 1.00%)}	_~	_0.83s	_0.85s	_{p=0.673 n=6}
_{Check Time}	_{8.06s (± 0.21%)}	_{8.07s (± 0.45%)}	_~	_8.01s	_8.11s	_{p=0.686 n=6}
_{Emit Time}	_{7.05s (± 0.24%)}	_{7.05s (± 0.34%)}	_~	_7.02s	_7.08s	_{p=0.808 n=6}
_{Total Time}	_{18.57s (± 0.11%)}	_{18.58s (± 0.25%)}	_~	_18.54s	_18.67s	_{p=0.870 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,104k (± 0.55%)}	_{194,458k (± 1.47%)}	_{+3,354k (+ 1.75%)}	_191,078k	_196,973k	_{p=0.013 n=6}
_{Parse Time}	_{1.35s (± 0.94%)}	_{1.34s (± 0.78%)}	_~	_1.33s	_1.36s	_{p=0.615 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.56%)}	_~	_0.73s	_0.74s	_{p=0.405 n=6}
_{Check Time}	_{9.20s (± 0.81%)}	_{9.16s (± 0.22%)}	_~	_9.13s	_9.19s	_{p=0.373 n=6}
_{Emit Time}	_{2.63s (± 0.44%)}	_{2.63s (± 0.85%)}	_~	_2.59s	_2.65s	_{p=0.451 n=6}
_{Total Time}	_{13.91s (± 0.50%)}	_{13.87s (± 0.20%)}	_~	_13.83s	_13.91s	_{p=0.106 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,230k (± 0.00%)}	_{348,860k (± 0.00%)}	_{+1,630k (+ 0.47%)}	_348,840k	_348,880k	_{p=0.005 n=6}
_{Parse Time}	_{2.46s (± 0.63%)}	_{2.46s (± 0.67%)}	_~	_2.43s	_2.48s	_{p=0.410 n=6}
_{Bind Time}	_{0.94s (± 0.00%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=1.000 n=6}
_{Check Time}	_{6.86s (± 0.53%)}	_{6.89s (± 0.40%)}	_~	_6.84s	_6.91s	_{p=0.169 n=6}
_{Emit Time}	_{4.02s (± 0.34%)}	_{4.03s (± 0.62%)}	_~	_4.00s	_4.07s	_{p=0.463 n=6}
_{Total Time}	_{14.27s (± 0.22%)}	_{14.31s (± 0.31%)}	_~	_14.24s	_14.38s	_{p=0.198 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,517k (± 0.01%)}	_{303,750k (± 0.01%)}	_{+1,233k (+ 0.41%)}	_303,715k	_303,784k	_{p=0.005 n=6}
_{Parse Time}	_{1.99s (± 1.21%)}	_{2.00s (± 0.92%)}	_~	_1.97s	_2.02s	_{p=0.405 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.01s (± 1.02%)}	_~	_0.99s	_1.02s	_{p=0.356 n=6}
_{Check Time}	_{6.25s (± 0.43%)}	_{6.28s (± 0.44%)}	_~	_6.24s	_6.32s	_{p=0.091 n=6}
_{Emit Time}	_{3.52s (± 0.67%)}	_{3.52s (± 0.39%)}	_~	_3.50s	_3.53s	_{p=0.934 n=6}
_{Total Time}	_{12.76s (± 0.21%)}	_{12.80s (± 0.30%)}	_~	_12.74s	_12.85s	_{p=0.054 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,486k (± 0.00%)}	_{474,320k (± 0.01%)}	_{+3,833k (+ 0.81%)}	_474,247k	_474,402k	_{p=0.005 n=6}
_{Parse Time}	_{2.57s (± 0.29%)}	_{2.57s (± 0.16%)}	_~	_2.56s	_2.57s	_{p=0.389 n=6}
_{Bind Time}	_{0.99s (± 0.52%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.784 n=6}
_{Check Time}	_{16.61s (± 0.45%)}	_{16.67s (± 0.39%)}	_~	_16.58s	_16.75s	_{p=0.171 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.35%)}	_{20.23s (± 0.33%)}	_~	_20.14s	_20.32s	_{p=0.128 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,630k (± 0.01%)}	_{515,328k (± 0.01%)}	_{+2,698k (+ 0.53%)}	_515,274k	_515,412k	_{p=0.005 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.27s (± 0.36%)}	_~	_3.25s	_3.28s	_{p=0.619 n=6}
_{Bind Time}	_{1.55s (± 0.53%)}	_{1.55s (± 0.58%)}	_~	_1.54s	_1.56s	_{p=0.550 n=6}
_{Check Time}	_{2.85s (± 0.60%)}	_{2.87s (± 0.87%)}	_~	_2.84s	_2.91s	_{p=0.167 n=6}
_{Emit Time}	_{0.08s (± 7.90%)}	_{0.08s (± 5.21%)}	_~	_0.07s	_0.08s	_{p=0.673 n=6}
_{Total Time}	_{7.74s (± 0.26%)}	_{7.76s (± 0.24%)}	_{+0.02s (+ 0.32%)}	_7.75s	_7.80s	_{p=0.020 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,358ms (± 1.11%)}	_{2,359ms (± 1.08%)}	_~	_2,325ms	_2,396ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,345ms (± 1.47%)}	_{5,411ms (± 1.75%)}	_~	_5,278ms	_5,526ms	_{p=0.230 n=6}
_{Req 3 - references}	_{326ms (± 0.36%)}	_{327ms (± 0.73%)}	_~	_326ms	_332ms	_{p=0.492 n=6}
_{Req 4 - navto}	_{278ms (± 0.95%)}	_{275ms (± 1.18%)}	_~	_272ms	_279ms	_{p=0.088 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 8.11%)}	_{87ms (± 6.92%)}	_~	_75ms	_91ms	_{p=0.106 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,485ms (± 0.89%)}	_{2,480ms (± 0.72%)}	_~	_2,467ms	_2,512ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,126ms (± 1.94%)}	_{4,140ms (± 2.11%)}	_~	_4,054ms	_4,232ms	_{p=0.471 n=6}
_{Req 3 - references}	_{336ms (± 1.08%)}	_{339ms (± 1.62%)}	_~	_333ms	_344ms	_{p=0.566 n=6}
_{Req 4 - navto}	_{284ms (± 0.29%)}	_{284ms (± 0.41%)}	_~	_283ms	_286ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 5.67%)}	_{82ms (± 7.39%)}	_~	_76ms	_87ms	_{p=0.465 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,600ms (± 0.38%)}	_{2,591ms (± 0.30%)}	_~	_2,582ms	_2,602ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{1,679ms (± 3.38%)}	_{1,713ms (± 2.64%)}	_~	_1,641ms	_1,758ms	_{p=0.230 n=6}
_{Req 3 - references}	_{106ms (± 0.93%)}	_{122ms (± 8.11%)}	_{🔻+16ms (+14.60%)}	_109ms	_130ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{359ms (± 0.38%)}	_{360ms (± 0.73%)}	_~	_358ms	_365ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{302ms (± 0.88%)}	_{306ms (± 2.15%)}	_~	_296ms	_314ms	_{p=0.222 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.09ms (± 0.18%)}	_{151.99ms (± 0.16%)}	_{-0.09ms (- 0.06%)}	_151.08ms	_155.83ms	_{p=0.001 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.68ms (± 0.16%)}	_{227.57ms (± 0.15%)}	_{-0.10ms (- 0.05%)}	_226.16ms	_232.36ms	_{p=0.007 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.46ms (± 0.19%)}	_{229.40ms (± 0.16%)}	_~	_227.94ms	_232.78ms	_{p=0.371 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.00ms (± 0.18%)}	_{229.05ms (± 0.16%)}	_{+0.05ms (+ 0.02%)}	_227.44ms	_231.72ms	_{p=0.046 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Hm, perf result indicates that adding this prop has moved Symbol into a new size class, given the memory increase.

@DanielRosenwasser

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/55887/merge:

Something interesting changed - please have a look.

Details

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

calcom/cal.com

Raw error text: RepoResults7/calcom.cal.com.rawError.txt in the artifact folder

Last few requests

{"seq":728,"type":"request","command":"navto","arguments":{"searchValue":"a","maxResultCount":256}}
{"seq":729,"type":"request","command":"navto","arguments":{"searchValue":"a1R","maxResultCount":256}}
{"seq":730,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/apps/api/test/lib/bookings/_post.test.ts"],"openFiles":[]}}
{"seq":731,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/web/components/AppListCard.tsx","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

git clone https://.com/calcom/cal.com --recurse-submodules
In dir cal.com, run git reset --hard 403d08de41d964466c6979f897c7b407fb7c569c
In dir cal.com, run yarn install --no-immutable --mode=skip-build
Back in the initial folder, download RepoResults7/calcom.cal.com.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./cal.com ./calcom.cal.com.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

@DanielRosenwasser

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/55887/merge:

Something interesting changed - please have a look.

Details

apollographql/apollo-client

1 of 10 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2454: Variable 'returnValue' is used before being assigned.
- src/testing/internal/profile/profile.tsx#L307

immich-app/immich

4 of 6 projects failed to build with the old tsc and were ignored

server/tsconfig.json

error TS2454: Variable 'a' is used before being assigned.
- server/src/immich/api-v1/asset/asset.service.spec.ts#L89

microsoft/playwright

4 of 14 projects failed to build with the old tsc and were ignored

utils/generate_types/test/tsconfig.json

error TS2454: Variable 'currentURL' is used before being assigned.
- utils/generate_types/test/test.ts#L164

microsoft/vscode

5 of 54 projects failed to build with the old tsc and were ignored

extensions/ipynb/tsconfig.json

error TS2454: Variable 'key' is used before being assigned.
- extensions/ipynb/src/helper.ts#L44

src/tsconfig.monaco.json

error TS2454: Variable 'key' is used before being assigned.
- src/vs/base/common/objects.ts#L130

src/tsconfig.tsec.json

error TS2454: Variable 'key' is used before being assigned.
error TS2454: Variable 'k' is used before being assigned.
- src/vs/workbench/contrib/notebook/common/model/notebookTextModel.ts#L956
- src/vs/workbench/contrib/notebook/common/model/notebookTextModel.ts#L997

pubkey/rxdb

8 of 10 projects failed to build with the old tsc and were ignored

config/tsconfig.types.json

error TS2454: Variable 'timeout' is used before being assigned.
- src/plugins/storage-lokijs/lokijs-helper.ts#L350

tsconfig.json

error TS2454: Variable 'timeout' is used before being assigned.
- src/plugins/storage-lokijs/lokijs-helper.ts#L350

snabbdom/snabbdom

test/tsconfig.json

error TS2454: Variable 'key' is used before being assigned.
error TS2454: Variable 'name' is used before being assigned.

tsconfig.json

error TS2454: Variable 'key' is used before being assigned.
error TS2454: Variable 'name' is used before being assigned.

tldraw/tldraw

1 of 5 projects failed to build with the old tsc and were ignored

Tonejs/Tone.js

1 of 2 projects failed to build with the old tsc and were ignored

scripts/tsconfig.build.json

error TS2454: Variable 'curveName' is used before being assigned.
- Tone/component/envelope/Envelope.ts#L226

video-dev/hls.js

tsconfig.json

error TS2454: Variable 'i' is used before being assigned.
- src/remux/mp4-generator.ts#L69

vuejs/core

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

error TS2454: Variable 'key' is used before being assigned.
- packages/compiler-core/src/parse.ts#L122

tsconfig.json

error TS2454: Variable 'key' is used before being assigned.
- packages/compiler-core/src/parse.ts#L122
- packages/template-explorer/src/index.ts#L122

vuetifyjs/vuetify

4 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.checks.json

error TS2454: Variable 'type' is used before being assigned.
- packages/vuetify/src/components/VGrid/VCol.ts#L120
- packages/vuetify/src/components/VGrid/VRow.ts#L126

packages/vuetify/tsconfig.dist.json

error TS2454: Variable 'type' is used before being assigned.
- packages/vuetify/src/components/VGrid/VCol.ts#L120
- packages/vuetify/src/components/VGrid/VRow.ts#L126

packages/vuetify/tsconfig.json

error TS2454: Variable 'type' is used before being assigned.
- packages/vuetify/src/components/VGrid/VCol.ts#L120
- packages/vuetify/src/components/VGrid/VRow.ts#L126

I spent a bit looking at the breaks and decided to take a break.

There was one example of a TODO which is questionable - I didn't quite understand that.

https://.com/immich-app/immich/blob/0a22e64799435a6ddf668733fab82da542e495f9/server/src/immich/api-v1/asset/asset.service.spec.ts#L89

For the most part, in the top 300 TypeScript projects on , the only real false negatives are variables that get assigned in a for/in or for/of loop. That seems like a bug and I'd like to rerun the tests once that's fixed.

https://.com/snabbdom/snabbdom/blob/420fa78abe98440d24e2c5af2f683e040409e0a6/src/modules/class.ts#L8-L18

https://.com/snabbdom/snabbdom/blob/420fa78abe98440d24e2c5af2f683e040409e0a6/src/modules/eventlisteners.ts#L56-L67

https://.com/snabbdom/snabbdom/blob/420fa78abe98440d24e2c5af2f683e040409e0a6/src/modules/style.ts#L29-L40

https://.com/snabbdom/snabbdom/blob/420fa78abe98440d24e2c5af2f683e040409e0a6/src/modules/style.ts#L70-L74

https://.com/microsoft/playwright/blob/c8143748e6af90df485dd46410915033b1001b73/utils/generate_types/test/test.ts#L164-L173

https://.com/microsoft/vscode/blob/c965b118a67c0f22895d2af899736d0e0aa82ffd/extensions/ipynb/src/helper.ts#L44-L58

https://.com/vuejs/core/blob/b8fc18c0b23be9a77b05dc41ed452a87a0becf82/packages/compiler-core/src/parse.ts#L122-L123

https://.com/vuejs/core/blob/b8fc18c0b23be9a77b05dc41ed452a87a0becf82/packages/template-explorer/src/index.ts#L122-L123

https://.com/vuetifyjs/vuetify/blob/3832f737c030d2f8a12b004473879f28689dc75e/packages/vuetify/src/components/VGrid/VCol.ts#L120-L121

https://.com/vuetifyjs/vuetify/blob/3832f737c030d2f8a12b004473879f28689dc75e/packages/vuetify/src/components/VGrid/VRow.ts#L126-L127

Just to be clear: "False negative" in this context means "this should be an error but isn't", correct?

I'm a little confused by the for..in examples - why would you write let foo; for (foo in whatever) ... instead of just for (let foo in whatever) ..., unless you're intending to use the variable outside the loop.

@gabritto

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163174/artifacts?artifactName=tgz&fileId=1B4C4A309A13E2A9D48577A04475E993BD4E3D22A5BB554494021DAA5A6D56E602&fileName=/typescript-5.6.0-insiders.20240807.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

src/compiler/checker.ts

@typescript-bot

@typescript-bot test it

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

tests/baselines/reference/unusedLocalsInMethod4.errors.txt

@gabritto

Hey @gabritto, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: svelte-leafletjs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/svelte-leafletjs/svelte-leafletjs-tests.ts
  74:66  error  TypeScript@local compile error: 
Variable 'getMap' is used before being assigned  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: raphael
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/raphael/test/raphael-tests-old.ts
  57:13  error  TypeScript@local compile error: 
Variable 'angle' is used before being assigned  @definitelytyped/expect
  58:60  error  TypeScript@local compile error: 
Variable 'angle' is used before being assigned  @definitelytyped/expect
  67:13  error  TypeScript@local compile error: 
Variable 'angle' is used before being assigned  @definitelytyped/expect
  68:53  error  TypeScript@local compile error: 
Variable 'angle' is used before being assigned  @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: nodal
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/nodal/nodal-tests.ts
  26:9  error  TypeScript@local compile error: 
Variable 'BlogPost' is used before being assigned  @definitelytyped/expect
  36:9  error  TypeScript@local compile error: 
Variable 'BlogPost' is used before being assigned  @definitelytyped/expect
  40:9  error  TypeScript@local compile error: 
Variable 'BlogPost' is used before being assigned  @definitelytyped/expect
  44:9  error  TypeScript@local compile error: 
Variable 'BlogPost' is used before being assigned  @definitelytyped/expect
  48:9  error  TypeScript@local compile error: 
Variable 'BlogPost' is used before being assigned  @definitelytyped/expect

✖ 5 problems (5 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: rx-lite-async
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rx-lite-async/rx-lite-async-tests.ts
   9:52  error  TypeScript@local compile error: 
Variable 'sch' is used before being assigned  @definitelytyped/expect
  15:45  error  TypeScript@local compile error: 
Variable 'sch' is used before being assigned  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: bluebird
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/bluebird/bluebird-tests.ts
   516:12  error  TypeScript@local compile error: 
Variable 'voidThen' is used before being assigned  @definitelytyped/expect
  1360:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1366:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1375:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1385:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1398:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1404:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1413:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1423:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1436:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1442:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1451:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1461:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1474:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1480:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1489:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect
  1499:12  error  TypeScript@local compile error: 
Variable 'boolThen' is used before being assigned  @definitelytyped/expect

✖ 17 problems (17 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@gabritto

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/55887/merge:

Everything looks good!

@gabritto

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,593k (± 0.93%)}	_{193,504k (± 0.97%)}	_~	_192,255k	_195,994k	_{p=1.000 n=6}
_{Parse Time}	_{1.95s (± 0.60%)}	_{1.95s (± 1.30%)}	_~	_1.93s	_1.99s	_{p=0.743 n=6}
_{Bind Time}	_{1.06s (± 1.39%)}	_{1.05s (± 1.55%)}	_~	_1.03s	_1.07s	_{p=0.615 n=6}
_{Check Time}	_{13.98s (± 0.34%)}	_{13.97s (± 0.39%)}	_~	_13.89s	_14.03s	_{p=0.873 n=6}
_{Emit Time}	_{4.00s (± 1.32%)}	_{4.00s (± 0.63%)}	_~	_3.95s	_4.02s	_{p=0.685 n=6}
_{Total Time}	_{20.98s (± 0.32%)}	_{20.97s (± 0.28%)}	_~	_20.90s	_21.04s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,757	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,045	_410,045	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,503k (± 0.00%)}	_{1,222,515k (± 0.00%)}	_~	_1,222,430k	_1,222,577k	_{p=0.378 n=6}
_{Parse Time}	_{7.92s (± 0.43%)}	_{7.93s (± 0.58%)}	_~	_7.88s	_7.99s	_{p=1.000 n=6}
_{Bind Time}	_{2.23s (± 0.23%)}	_{2.23s (± 0.37%)}	_~	_2.22s	_2.24s	_{p=0.929 n=6}
_{Check Time}	_{36.24s (± 0.51%)}	_{36.27s (± 0.34%)}	_~	_36.09s	_36.39s	_{p=0.520 n=6}
_{Emit Time}	_{17.81s (± 0.69%)}	_{17.81s (± 0.42%)}	_~	_17.71s	_17.89s	_{p=0.872 n=6}
_{Total Time}	_{64.21s (± 0.43%)}	_{64.24s (± 0.20%)}	_~	_64.05s	_64.37s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,487,631	_2,487,631	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,012,953	_1,012,953	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,493,460k (± 0.00%)}	_{2,493,494k (± 0.00%)}	_~	_2,493,441k	_2,493,532k	_{p=0.230 n=6}
_{Parse Time}	_{10.94s (± 0.07%)}	_{10.98s (± 0.29%)}	_{+0.04s (+ 0.37%)}	_10.94s	_11.02s	_{p=0.028 n=6}
_{Bind Time}	_{2.61s (± 0.54%)}	_{2.62s (± 0.24%)}	_~	_2.61s	_2.63s	_{p=0.180 n=6}
_{Check Time}	_{89.42s (± 0.42%)}	_{89.24s (± 0.69%)}	_~	_88.72s	_90.42s	_{p=0.378 n=6}
_{Emit Time}	_{0.33s (± 2.50%)}	_{0.33s (± 1.91%)}	_~	_0.32s	_0.34s	_{p=0.432 n=6}
_{Total Time}	_{103.30s (± 0.35%)}	_{103.18s (± 0.59%)}	_~	_102.70s	_104.34s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,292	_1,229,303	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,032	_264,036	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,526,174k (± 7.71%)}	_{2,348,495k (± 0.03%)}	_~	_2,346,949k	_2,348,862k	_{p=0.689 n=6}
_{Parse Time}	_{6.07s (± 1.16%)}	_{6.01s (± 0.43%)}	_~	_5.98s	_6.05s	_{p=0.128 n=6}
_{Bind Time}	_{2.23s (± 1.41%)}	_{2.25s (± 1.17%)}	_~	_2.23s	_2.29s	_{p=0.228 n=6}
_{Check Time}	_{40.50s (± 0.95%)}	_{40.76s (± 0.46%)}	_~	_40.63s	_41.14s	_{p=0.575 n=6}
_{Emit Time}	_{3.96s (± 0.78%)}	_{3.96s (± 1.02%)}	_~	_3.90s	_4.01s	_{p=0.936 n=6}
_{Total Time}	_{52.79s (± 0.64%)}	_{53.01s (± 0.45%)}	_~	_52.85s	_53.49s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,292	_1,229,303	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,032	_264,036	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,599,692k (±11.39%)}	_{2,541,443k (± 7.20%)}	_~	_2,422,947k	_2,778,511k	_{p=0.471 n=6}
_{Parse Time}	_{7.80s (± 0.81%)}	_{7.77s (± 0.99%)}	_~	_7.63s	_7.86s	_{p=0.575 n=6}
_{Bind Time}	_{2.49s (± 1.45%)}	_{2.55s (± 2.02%)}	_~	_2.48s	_2.61s	_{p=0.065 n=6}
_{Check Time}	_{50.85s (± 0.74%)}	_{50.65s (± 0.83%)}	_~	_49.91s	_51.04s	_{p=0.575 n=6}
_{Emit Time}	_{5.00s (± 1.10%)}	_{5.02s (± 2.06%)}	_~	_4.91s	_5.21s	_{p=0.936 n=6}
_{Total Time}	_{66.17s (± 0.55%)}	_{66.02s (± 0.61%)}	_~	_65.37s	_66.56s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,694	_256,705	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,545	_105,549	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,877k (± 0.03%)}	_{428,954k (± 0.02%)}	_~	_428,795k	_429,086k	_{p=0.336 n=6}
_{Parse Time}	_{4.16s (± 0.45%)}	_{4.16s (± 0.35%)}	_~	_4.14s	_4.18s	_{p=0.808 n=6}
_{Bind Time}	_{1.61s (± 1.08%)}	_{1.62s (± 1.26%)}	_~	_1.58s	_1.64s	_{p=0.492 n=6}
_{Check Time}	_{22.29s (± 0.33%)}	_{22.34s (± 0.41%)}	_~	_22.22s	_22.45s	_{p=0.575 n=6}
_{Emit Time}	_{2.03s (± 0.80%)}	_{2.02s (± 0.92%)}	_~	_2.00s	_2.04s	_{p=0.121 n=6}
_{Total Time}	_{30.09s (± 0.25%)}	_{30.14s (± 0.30%)}	_~	_30.00s	_30.24s	_{p=0.686 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₆₈	_{🔻+33 (+94.29%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,249	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{370,167k (± 0.02%)}	_{370,102k (± 0.02%)}	_~	_370,025k	_370,177k	_{p=0.173 n=6}
_{Parse Time}	_{2.76s (± 0.32%)}	_{2.75s (± 0.59%)}	_~	_2.73s	_2.77s	_{p=0.563 n=6}
_{Bind Time}	_{1.57s (± 1.25%)}	_{1.57s (± 1.02%)}	_~	_1.55s	_1.59s	_{p=0.931 n=6}
_{Check Time}	_{15.61s (± 0.20%)}	_{15.70s (± 0.20%)}	_{+0.09s (+ 0.58%)}	_15.67s	_15.74s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.94s (± 0.12%)}	_{20.01s (± 0.22%)}	_{+0.07s (+ 0.36%)}	_19.95s	_20.07s	_{p=0.016 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₆₆	_{🔻+66 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,995,242	_2,995,242	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,032,059	_1,032,059	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,120,638k (± 0.00%)}	_{3,120,752k (± 0.00%)}	_{+114k (+ 0.00%)}	_3,120,677k	_3,120,934k	_{p=0.020 n=6}
_{Parse Time}	_{17.08s (± 0.30%)}	_{17.03s (± 0.28%)}	_~	_16.95s	_17.08s	_{p=0.226 n=6}
_{Bind Time}	_{5.23s (± 0.23%)}	_{5.22s (± 0.30%)}	_~	_5.20s	_5.24s	_{p=0.611 n=6}
_{Check Time}	_{96.45s (± 0.59%)}	_{96.61s (± 0.16%)}	_~	_96.34s	_96.78s	_{p=0.470 n=6}
_{Emit Time}	_{25.00s (± 0.60%)}	_{24.85s (± 0.41%)}	_~	_24.69s	_24.95s	_{p=0.128 n=6}
_{Total Time}	_{143.76s (± 0.44%)}	_{143.72s (± 0.15%)}	_~	_143.39s	_143.99s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_273,789	_273,789	_~	_~	_~	_{p=1.000 n=6}
_Types	_111,669	_111,669	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{419,898k (± 0.02%)}	_{419,891k (± 0.02%)}	_~	_419,795k	_420,010k	_{p=1.000 n=6}
_{Parse Time}	_{3.30s (± 0.45%)}	_{3.30s (± 0.30%)}	_~	_3.29s	_3.31s	_{p=0.796 n=6}
_{Bind Time}	_{1.45s (± 1.01%)}	_{1.46s (± 1.53%)}	_~	_1.43s	_1.49s	_{p=0.626 n=6}
_{Check Time}	_{14.49s (± 0.44%)}	_{14.53s (± 0.64%)}	_~	_14.42s	_14.68s	_{p=0.521 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.25s (± 0.32%)}	_{19.29s (± 0.60%)}	_~	_19.17s	_19.46s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,614	_538,614	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,536	_176,536	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,472k (± 0.01%)}	_{481,460k (± 0.00%)}	_~	_481,441k	_481,489k	_{p=0.810 n=6}
_{Parse Time}	_{4.25s (± 0.61%)}	_{4.25s (± 0.69%)}	_~	_4.20s	_4.28s	_{p=0.685 n=6}
_{Bind Time}	_{1.55s (± 0.53%)}	_{1.55s (± 0.33%)}	_~	_1.54s	_1.55s	_{p=0.929 n=6}
_{Check Time}	_{22.25s (± 0.30%)}	_{22.34s (± 0.35%)}	_~	_22.24s	_22.46s	_{p=0.124 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.05s (± 0.27%)}	_{28.14s (± 0.38%)}	_~	_27.98s	_28.28s	_{p=0.148 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

@gabritto

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/55887/merge:

Something interesting changed - please have a look.

Details

immich-app/immich

2 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.json

error TS2454: Variable 'accessMock' is used before being assigned.
- server/src/services/partner.service.spec.ts#L17

microsoft/vscode

4 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.json

pubkey/rxdb

8 of 11 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2454: Variable 'timeout' is used before being assigned.
- src/plugins/storage-lokijs/lokijs-helper.ts#L366

config/tsconfig.types.json

error TS2454: Variable 'timeout' is used before being assigned.
- src/plugins/storage-lokijs/lokijs-helper.ts#L366

@typescript-bot

@typescript-bot pack this

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

@DanielRosenwasser

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163380/artifacts?artifactName=tgz&fileId=FA4786617EC62F6D82F4F215B7B541D15CEF997545365AE0E862D7EE6C7917F502&fileName=/typescript-5.6.0-insiders.20240819.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Apart from my nits I think this is ready. Excited to get this into 5.7!

src/compiler/checker.ts

tests/baselines/reference/narrowingPastLastAssignment.errors.txt

src/compiler/transformers/es2015.ts

Changes were addressed

error on variables that are used but never uninitialized

ecf36a7

typescript-bot added the For Backlog BugPRs that fix a backlog buglabel Sep 27, 2023

Zzzen commented Sep 27, 2023
View reviewed changes

Zzzen added 2 commits September 27, 2023 15:06

format

8416f98

Merge remote-tracking branch 'origin/main' into check-uninitialized-v…

54183fd
…ariables

Zzzen marked this pull request as draft September 27, 2023 07:36

fix tests

ff025b3

Zzzen marked this pull request as ready for review September 27, 2023 07:57

Zzzen changed the title ~~error on variables that are used but never uninitialized~~ error on variables that are used but never initialized Sep 27, 2023

DanielRosenwasser reviewed Sep 27, 2023
View reviewed changes

src/compiler/types.ts Outdated Show resolved Hide resolved

Zzzen added 2 commits September 28, 2023 15:48

fix ForInOrOfStatement

7bb240f

reuse isAssigned flag

8d814cd

gabritto requested changes Aug 7, 2024
View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

ignore var variables

10e2cf8

gabritto approved these changes Aug 8, 2024
View reviewed changes

tests/baselines/reference/unusedLocalsInMethod4.errors.txt Outdated Show resolved Hide resolved
tests/baselines/reference/unusedLocalsInMethod4.errors.txt Outdated Show resolved Hide resolved

gabritto requested a review from DanielRosenwasser August 8, 2024 23:43

update test

6c85362

DanielRosenwasser previously requested changes Aug 19, 2024
View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved
tests/baselines/reference/narrowingPastLastAssignment.errors.txt Show resolved Hide resolved
src/compiler/transformers/es2015.ts Outdated Show resolved Hide resolved

update code

b930faa

gabritto requested a review from DanielRosenwasser August 20, 2024 17:40

gabritto approved these changes Aug 20, 2024
View reviewed changes

gabritto merged commit 533ed3d into microsoft:main Aug 20, 2024
30 checks passed

DanielRosenwasser mentioned this pull request Sep 9, 2024
TypeScript 5.7 Iteration Plan #59905
Closed

kirkwaiblinger mentioned this pull request Sep 26, 2024
Create flag strictVariableInitialization #60064
Open
6 tasks

kirkwaiblinger mentioned this pull request Oct 9, 2024
Uninitialized local check still permits provably erroneous use-before-assign in closure #60181
Open

sandersn removed this from PR Backlog Apr 22, 2025

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

/mnt/ts_downloads/pyright/build.sh

Uh oh!

Compiler

tsserver

Startup

Uh oh!

Uh oh!

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tsc

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!