Conversation

dav-pascual

Fixes: #88 and docs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! The integration tests are failing with the new changes. Can you please modify the integration tests such that they test for the new functionality?

@dekobon

I've been doing some research on how to fix the integration tests and I've been unable to find a method of normalizing slashes using rewrite rules that will preserve the requested schema, hostname, and port. I think we may have to implement this in njs. I did a in njs and it was relatively simple to normalize the uri requested to S3, but it does not result in a HTTP 302 redirect to the client. I'll update as I discover more.

@dav-pascual

I have not taken a a look yet at the integration tests yet, but if the njs solution serves the content correctly even if it doesn't rewrite the URL / redirect in the client I think that's a valid solution.

In a previous unsuccessful attempt in njs I was getting 404 errors after normalising "uri_path" variable.

@dav-pascualdav-pascual force-pushed the master branch 10 times, most recently from 0cd76e7 to e6f9460 Compare March 6, 2023 21:35
@dav-pascual

I tried updating the integration tests to expect a 302 code redirect when there is a double slash, but I am getting a error code return 7 from the run, without much detail

@dekobon

@dav-pascual - I'm traveling right now, so it will be a while until I can engage on this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Remove double/multiple forward slashes from the request path