+8 −7

Conversation

catatsuy

The build system had two issues when zlib-ng is used:

  1. distclean was always invoked, causing failure on first run when no Makefile exists yet.
  2. There was no way to pass options like --zlib-compat to zlib's ./configure; users tried to sneak them in via CFLAGS which triggers "compiler error reporting is too harsh" and aborts.

The new --with-zlib-conf-opt= option feeds its value directly to ./configure, and distclean is now executed only if a Makefile is present.

@catatsuy
auto/lib/zlib: add --with-zlib-conf-opt and skip missing distclean
4e2cc51
The build system had two issues when zlib-ng is used:
1. `distclean` was always invoked, causing failure on first run
   when no Makefile exists yet.
2. There was no way to pass options like --zlib-compat to zlib's
   ./configure; users tried to sneak them in via CFLAGS which
   triggers "compiler error reporting is too harsh" and aborts.

The new --with-zlib-conf-opt=<opts> option feeds its value
directly to ./configure, and `distclean` is now executed only
if a Makefile is present.
@catatsuycatatsuy changed the title auto/lib/zlib: add --with-zlib-conf-opt and skip missing distclean auto/lib/zlib: fix zlib-ng build bug—skip distclean when no Makefile & add configure option May 3, 2025
@catatsuycatatsuy mentioned this pull request May 10, 2025
Draft
Sign up for free to join this conversation on . Already have an account? Sign in to comment
No reviews
No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.

@catatsuy