Conversation

mgxd

This is an effort to remove a manual step in the release process.

Currently, we are submitting a PR to the tutorials repo to build from the current release branch.

This proposes a new action that runs whenever an upstream rel/* branch is pushed to that:

  1. Triggers a "manual" dis to the tutorial's action
  2. Tracks the status of the job until it i) succeeds, ii) fails, or iii) hits the timeout (currently 1 hour)

For this to work, it will require (cc @djarecka who may have the proper permissions):

  1. ENH: Allow GH Action to run with manual trigger miykael/nipype_tutorial#180 to be merged in
  2. A PAT for the nipype_tutorial repo to be created and added to this organization's secrets as TUTORIAL_ACCESS_TOKEN

@codecov

Codecov Report

Merging #3504 (2b15c0b) into master (71411b0) will decrease coverage by 1.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
- Coverage   65.25%   63.63%   -1.63%     
==========================================
  Files         309      309              
  Lines       40859    40859              
  Branches     5379     5379              
==========================================
- Hits        26663    25999     -664     
- Misses      13126    13835     +709     
+ Partials     1070     1025      -45     
FlagCoverage Δ
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
nipype/workflows/__init__.py47.05% <0.00%> (-52.95%)⬇️
nipype/utils/spm_docs.py20.00% <0.00%> (-48.00%)⬇️
nipype/testing/fixtures.py57.14% <0.00%> (-41.56%)⬇️
nipype/interfaces/freesurfer/base.py48.38% <0.00%> (-28.23%)⬇️
nipype/utils/logger.py56.92% <0.00%> (-27.70%)⬇️
nipype/interfaces/fsl/maths.py79.06% <0.00%> (-19.19%)⬇️
nipype/interfaces/dcm2nii.py50.00% <0.00%> (-15.28%)⬇️
nipype/interfaces/fsl/base.py67.02% <0.00%> (-13.83%)⬇️
nipype/interfaces/fsl/preprocess.py61.04% <0.00%> (-10.50%)⬇️
nipype/interfaces/spm/base.py60.06% <0.00%> (-7.60%)⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@effigies

@mgxd @djarecka Is this something that should go in soon? I was thinking of dropping a bugfix release, and I'm game to try it out if this can go in quickly.

@mgxd

We need to create/add a PAT (repo scoped) and assign it as TUTORIAL_ACCESS_TOKEN. However, that user has to have admin access on the tutorials - which I think is limited to dorota or miykael. Maybe we could add @nipybot as an admin?

@djarecka

unfortunately I don't have admin access to the tutorial... I have write access and can merge your PRs, but I don't have access to the settings :(

@mgxd

Sorry, I think I misspoke. I believe if you can trigger the workflow here (https://.com/miykael/nipype_tutorial/actions) then you have sufficient permissions

@djarecka

yes, I can rerun jobs and I have access to New workflow. Do you have some instruction that I can follow to set it? Or perhaps we can have a quick call and do it together?

@mgxdmgxd marked this pull request as ready for review September 20, 2022 20:56
@djareckadjarecka merged commit e5be008 into nipy:master Sep 20, 2022
@mgxdmgxd deleted the maint/tutorial-trigger branch September 20, 2022 20:59
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.