Conversation

effigies

Bug introduced in #3489. Numpy 1.22 introduced method and deprecated interpolation in a single shot. Typically, they deprecate a few versions after they introduce an alternative, so I missed this and now things that have pinned, e.g., numpy 1.21 are going to break on nipype.

@codecov

Codecov Report

Base: 65.26% // Head: 65.25% // Decreases project coverage by -0.00%⚠️

Coverage data is based on head (188ebbd) compared to base (fd39c1f).
coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3506      +/-   ##
==========================================
- Coverage   65.26%   65.25%   -0.01%     
==========================================
  Files         309      309              
  Lines       40870    40873       +3     
  Branches     5380     5380              
==========================================
+ Hits        26672    26673       +1     
- Misses      13124    13126       +2     
  Partials     1074     1074              
FlagCoverage Δ
unittests65.03% <50.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
nipype/algorithms/confounds.py67.17% <50.00%> (-0.18%)⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies

@mgxd Would you mind giving this a quick glance?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - is this something we should track and remove once 1.22 becomes the minimum?

@effigies

I generally try to grep for PY strings when bumping minimum Python and NP strings when bumping minimum numpy, so the comment there is my tracking plan.

@effigieseffigies merged commit 4d51686 into nipy:master Sep 20, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.