Conversation

DimitriPapadopoulos

Summary

Fix typos.

List of changes proposed in this PR (pull-request)

  • Fix the rest of the typos found by codespell.
  • Remove spaces at end of line.
  • Remove empty lines at end of file.
  • Run black on files that require it to pass tests.

@DimitriPapadopoulosDimitriPapadopoulos marked this pull request as ready for review September 21, 2022 07:30
@codecov

Codecov Report

Base: 65.25% // Head: 64.41% // Decreases project coverage by -0.84%⚠️

Coverage data is based on head (326880d) compared to base (e5be008).
coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3512      +/-   ##
==========================================
- Coverage   65.25%   64.41%   -0.85%     
==========================================
  Files         309      309              
  Lines       40873    40873              
  Branches     5380     5380              
==========================================
- Hits        26673    26329     -344     
- Misses      13126    13484     +358     
+ Partials     1074     1060      -14
FlagCoverage Δ
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
nipype/caching/memory.py57.37% <ø> (ø)
nipype/interfaces/afni/base.py64.06% <ø> (-5.47%)⬇️
nipype/interfaces/afni/preprocess.py81.00% <ø> (-0.55%)⬇️
nipype/interfaces/c3.py65.71% <ø> (ø)
nipype/interfaces/dcmstack.py35.10% <ø> (ø)
nipype/interfaces/io.py48.06% <ø> (-7.14%)⬇️
nipype/interfaces/matlab.py74.72% <ø> (-3.30%)⬇️
nipype/interfaces/minc/minc.py85.20% <ø> (ø)
nipype/interfaces/petpvc.py54.71% <ø> (ø)
nipype/interfaces/semtools/brains/segmentation.py100.00% <ø> (ø)
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

effigies
effigies requested changes Sep 21, 2022
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I think we should revert the nipype/interfaces/fsl/model_templates/ directory.

nipype/interfaces/fsl/model_templates/feat_contrastmask_element.tcl Outdated
@@ -1,3 +1,2 @@
# Mask real contrast/F-test $c1 with real contrast/F-test $c2?
set fmri(conmask${c1}_${c2}) 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for template files, we should leave them alone. These are meant to be snippets to compile as inputs to tools, and I don't have an immediate plan to generate before/after files that would use all of these and decide whether the whitespace improved readability or possibly was significant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted nipype/interfaces/fsl/model_templates/*.

@DimitriPapadopoulos
MNT: spaces and empty lines
b303733
Remove:
- spaces at end of line,
- empty lines at end of file.
@DimitriPapadopoulos
STY: Fix black formatting
326880d
effigies
effigies approved these changes Sep 21, 2022
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@effigieseffigies merged commit c634f29 into nipy:master Sep 21, 2022
@DimitriPapadopoulosDimitriPapadopoulos deleted the codespell branch September 21, 2022 16:24
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@effigies effigies effigies approved these changes

No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.