Conversation

mgxd

Currently, after the tutorial workflow is dised, it runs to completion, regardless of our workflow ending early. This adds a step to cancel the workflow upon failure or cancellation, to avoid overbearing the external runners.

@codecov

Codecov Report

Base: 65.29% // Head: 64.41% // Decreases project coverage by -0.87%⚠️

Coverage data is based on head (740bdc1) compared to base (1025526).
has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
- Coverage   65.29%   64.41%   -0.88%     
==========================================
  Files         309      309              
  Lines       40873    40873              
  Branches     5380     5380              
==========================================
- Hits        26687    26329     -358     
- Misses      13108    13484     +376     
+ Partials     1078     1060      -18     
FlagCoverage Δ
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
nipype/workflows/__init__.py47.05% <0.00%> (-52.95%)⬇️
nipype/utils/spm_docs.py20.00% <0.00%> (-48.00%)⬇️
nipype/interfaces/freesurfer/base.py48.38% <0.00%> (-28.23%)⬇️
nipype/utils/logger.py56.92% <0.00%> (-27.70%)⬇️
nipype/testing/fixtures.py77.92% <0.00%> (-20.78%)⬇️
nipype/interfaces/dcm2nii.py50.00% <0.00%> (-15.28%)⬇️
nipype/interfaces/spm/base.py60.06% <0.00%> (-7.60%)⬇️
nipype/interfaces/io.py48.06% <0.00%> (-7.14%)⬇️
nipype/interfaces/cat12/surface.py59.34% <0.00%> (-6.60%)⬇️
nipype/pkg_info.py75.00% <0.00%> (-6.25%)⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxdmgxd marked this pull request as ready for review September 21, 2022 15:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is good, as combined with concurrency it will ensure that multiple commits to a release branch don't just flood the the tutorial CI.

@mgxdmgxd merged commit b1cc5b6 into nipy:master Sep 21, 2022
@mgxdmgxd deleted the ci/tutorial-cancel branch September 21, 2022 20:01
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.