Conversation

manuegrx

If factorial design is used for fMRI model specification (parameter "factor_info" in Level1design), spm automatically creates contrasts (con*, ess*, spmF* and spmT* images) during model estimation (EstimateModel).

Those outputs are not yet in EstimateModel in Nipype, the aim of this PR is to add them.

Issue : #3576

@codecov

Codecov Report

coverage: 25.00% and project coverage change: -0.02⚠️

Comparison is base (68a7cd4) 63.19% compared to head (1467f1c) 63.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
- Coverage   63.19%   63.18%   -0.02%     
==========================================
  Files         308      308              
  Lines       40792    40808      +16     
  Branches     5489     5653     +164     
==========================================
+ Hits        25779    25783       +4     
- Misses      14000    14012      +12     
  Partials     1013     1013              
Impacted FilesCoverage Δ
nipype/interfaces/spm/model.py42.25% <25.00%> (-0.68%)⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Please note that nipype is not very actively maintained and does not have a specific release schedule, and you may find it easier to maintain your own interfaces in the packages that need them.

If you are interested in helping with the maintenance, let us know.

@effigieseffigies force-pushed the bugfix_spm_model branch from 7419286 to 1467f1c Compare July 5, 2023 21:03
@effigieseffigies merged commit 40199f1 into nipy:master Jul 5, 2023
@manuegrx

Thank you very much !

@manuegrxmanuegrx deleted the bugfix_spm_model branch July 6, 2023 06:59
@effigieseffigies mentioned this pull request Mar 20, 2024
6 tasks
@effigieseffigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.