Conversation

DimitriPapadopoulos

Summary

Apply assorted flake8-simplify (SIM) rules.

@codecovCodecov

Codecov Report

Attention: coverage is 30.00000% with 63 lines in your changes missing coverage. Please review.

Project coverage is 70.89%. Comparing base (6ac81ca) to head (d040d84).
Report is 144 commits behind head on master.

Files with missing lines%Lines
nipype/interfaces/slicer/generate_classes.py0.00%12 Missing and 1 partial⚠️
nipype/interfaces/fsl/model.py21.42%10 Missing and 1 partial⚠️
nipype/interfaces/cmtk/convert.py0.00%7 Missing⚠️
nipype/interfaces/cmtk/cmtk.py0.00%6 Missing⚠️
nipype/interfaces/cmtk/nx.py0.00%6 Missing⚠️
nipype/algorithms/misc.py0.00%4 Missing⚠️
nipype/interfaces/io.py0.00%3 Missing⚠️
nipype/interfaces/afni/model.py0.00%2 Missing⚠️
nipype/utils/draw_gantt_chart.py0.00%2 Missing⚠️
nipype/interfaces/afni/utils.py0.00%1 Missing⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3676      +/-   ##
==========================================
+ Coverage   70.87%   70.89%   +0.02%     
==========================================
  Files        1276     1276              
  Lines       59238    59209      -29     
  Branches     9812     9814       +2     
==========================================
- Hits        41984    41977       -7     
+ Misses      16079    16061      -18     
+ Partials     1175     1171       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimitriPapadopoulosDimitriPapadopoulos force-pushed the SIM branch 2 times, most recently from ba2eac6 to a2681fa Compare October 6, 2024 13:43
effigies
effigies reviewed Oct 6, 2024
View reviewed changes
effigies
effigies reviewed Oct 6, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a couple new things.

effigies
effigies approved these changes Oct 6, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a merge conflict resolved, but otherwise good to go.

DimitriPapadopoulos and others added 8 commits October 6, 2024 17:58
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM101
eb1d488
SIM101 Multiple `isinstance` calls for expression, merge into a single call
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM103
01c3e76
SIM103 Return the condition directly
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM113
4b88c39
SIM113 Use `enumerate()` for index variable in `for` loop
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM115
d294476
SIM115 Use a context manager for opening files
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM118
697297b
SIM118 Use `key in dict` instead of `key in dict.keys()`
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM201
d557f71
SIM201 Use `... != ...` instead of `not ... == ...`
@DimitriPapadopoulos
STY: Apply ruff/flake8-simplify rule SIM401
5f200ce
SIM401 Use `.get()` instead of an `if` block
@DimitriPapadopoulos @effigies
STY: Further simplification
d040d84
Co-authored-by: Chris Markiewicz <[email protected]>
@effigieseffigies merged commit ccec546 into nipy:master Oct 6, 2024
19 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@effigies effigies effigies approved these changes

No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.