Conversation

man-shu

Summary

Fixes #3712 .

List of changes proposed in this PR (pull-request)

  • try getting the len of idxs
  • if it fails with TypeError (which happens when idxs is a 0D array)
  • set nels to 1

@effigies

@man-shu I'm not sure if this code actually gets tested by our tests. If you're testing on your end, please make sure that it works in cases where it was previously failing.

@codecovCodecov

Codecov Report

Attention: coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.84%. Comparing base (fe20d45) to head (12f7023).

Files with missing lines%Lines
nipype/algorithms/misc.py0.00%3 Missing⚠️

❗ There is a different number of reports uploaded between BASE (fe20d45) and HEAD (12f7023). Click for more details.

HEAD has 21 uploads less than BASE
FlagBASE (fe20d45)HEAD (12f7023)
221
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3713       +/-   ##
===========================================
- Coverage   73.07%   50.84%   -22.23%     
===========================================
  Files        1278     1278               
  Lines       59406    59367       -39     
===========================================
- Hits        43411    30187    -13224     
- Misses      15995    29180    +13185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@man-shu

@man-shu I'm not sure if this code actually gets tested by our tests. If you're testing on your end, please make sure that it works in cases where it was previously failing.

Ok will update you on that.

@effigies

@man-shu Have you had a chance to test this?

@man-shu

Sorry not yet! Our HPC has been down since the day I opened this PR. Our IT dept is telling us that it should be ok by next week, so I hope to get back to you then.

(I tried copying the original nipype cache locally and then run it, but then it just started a fresh run because the checksum didn't match.)

@man-shu

Hello @effigies ! I finally ran the full pipeline with and without this fix and both of them worked.
So I don't think either of them were hitting this case.

I do not have access to the cache for the failing run either.

Do you have any suggestions on how to proceed from here?

@effigies

Just need to eyeball it, then.

It still looks right to me after a few weeks, so let's merge.

@effigieseffigies merged commit 13228e8 into nipy:master Mar 17, 2025
1 check passed
effigies added a commit that referenced this pull request Mar 19, 2025
1.10.0 (March 19, 2025)

New feature release in the 1.10.x series.

This release adds GPUs to multiprocess resource management.
In general, no changes to existing code should be required if the GPU-enabled
interface has a ``use_gpu`` input.
The ``n_gpu_procs`` can be used to set the number of GPU processes that may
be run in parallel, which will override the default of GPUs identified by
``nvidia-smi``, or 1 if no GPUs are detected.

* FIX: Reimplement ``gpu_count()`` (#3718)
* FIX: Avoid 0D array in ``algorithms.misc.merge_rois`` (#3713)
* FIX: Allow nipype.sphinx.ext.apidoc Config to work with Sphinx 8.2.1+ (#3716)
* FIX: Resolve crashes when running workflows with updatehash=True (#3709)
* ENH: Support for gpu queue (#3642)
* ENH: Update to .wci.yml (#3708)
* ENH: Add Workflow Community Initiative (WCI) descriptor (#3608)
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[BUG] Merging rois outputs from bedpostx_parallel fails