+17 −29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Could also just call this a bugfix since we're going from raising to not raising |
Yeah I would be okay calling this a bug fix |
Changed from deprecation to bugfix |
mroeschke approved these changes May 19, 2023
Thanks @jbrockmendel |
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
…s-dev#53291) * DEPR: allow DataFrame[mask]=value with mixed non-numeric dtypes * Change deprecation to bugfix
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…s-dev#53291) * DEPR: allow DataFrame[mask]=value with mixed non-numeric dtypes * Change deprecation to bugfix
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Looks like this check was implemented to avoid some inconsistency, but I can no longer find what that inconsistency was.