Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
phofl reviewed Oct 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
Go for it. For a major release I think we're OK being really aggressive on this front. |
| super().test_from_dtype(data) | ||
| def test_from_sequence_pa_array(self, data, request): | ||
| # https://.com/pandas-dev/pandas/pull/47034#discussion_r955500784 | ||
| # data._data = pa.ChunkedArray | ||
| if pa_version_under3p0: |
There was a problem hiding this comment.
ive been looking forward to seeing these go!
I would also be +1 to a 6.0 bump |
+1 in 6.0 as well |
phofl approved these changes Oct 17, 2022
thx @mroeschke |
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Would help #47781 and #49078
1.0.1 was released on August 21, 2020 and 5.0.0 was released July 28 2021 (almost a year later).
Last time optional dependencies were bumped (#47048), the versions were based on the version released ~1 year prior, so given that logic, could even bump to 6.0.0 (October 26, 2021)